Bug 415605

Summary: Full Screen toolbar item is shown in French while my config is in English
Product: [Applications] digikam Reporter: Alexandre Belz <alexandre.belz>
Component: Usability-i18nAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: caulier.gilles, herb.k, metzpinguin
Priority: NOR    
Version First Reported In: 7.2.0   
Target Milestone: ---   
Platform: Microsoft Windows   
OS: Microsoft Windows   
Latest Commit: Version Fixed In: 7.5.0
Sentry Crash Report:
Attachments: Screen capture of the "bug".
Screen capture of the bug with Spanish context.

Description Alexandre Belz 2019-12-27 11:09:16 UTC
Created attachment 124734 [details]
Screen capture of the "bug".

SUMMARY
Full Screen toolbar item is shown in French ("Plein Ecran") while my config is in English.

STEPS TO REPRODUCE
1. 
2. 
3. 

OBSERVED RESULT
Full Screen toolbar item is shown in French "Plein Ecran".
See attached screen capture.

EXPECTED RESULT
Full Screen toolbar item should be in English (like other items) = "Full Screen".

SOFTWARE/OS VERSIONS
Windows:10
Comment 1 caulier.gilles 2019-12-27 11:24:25 UTC
Strange. Did you restart the application before to switch the language (from French to English)

I do not see a reason for that as the rest of the tool bar is show in English as well). Only Full-Screen button still in French.

Gilles Caulier
Comment 2 Alexandre Belz 2019-12-27 13:11:22 UTC
Yes i did restart.
It's beeing several weeks i've setup my digikam in English to ease the screen captures and Bug reporting.
i only noticed this strange this today.

Note that my Windows is in French.
Comment 3 caulier.gilles 2019-12-27 13:25:49 UTC
The internationalization of GUI do not use OS locale. It's just an application option to switch in language to another one.

Can you reproduce this kind of dysfunction with :

Another language, like German for ex ?

Another KDE application ported to Windows, as Krita, Marble, Kate, etc...

Gilles Caulier
Comment 4 Alexandre Belz 2019-12-27 13:49:29 UTC
Same problem in spanish.
See attached screen capture
Comment 5 Alexandre Belz 2019-12-27 13:50:12 UTC
Created attachment 124738 [details]
Screen capture of the bug with Spanish context.

Note that I did not set a fallback language.
Comment 6 Maik Qualmann 2019-12-27 21:19:18 UTC
Git commit 703d0bbe0de98e09c0010ab48c16171066d97e68 by Maik Qualmann.
Committed on 27/12/2019 at 21:17.
Pushed by mqualmann into branch 'master'.

try to fix translation domain from KStandardAction::fullScreen()

M  +1    -1    core/libs/widgets/mainview/dxmlguiwindow.cpp

https://invent.kde.org/kde/digikam/commit/703d0bbe0de98e09c0010ab48c16171066d97e68
Comment 7 Alexandre Belz 2019-12-27 22:40:22 UTC
Thank you Maik.
I will test after next Windows build.
(i just have windows, not Linux).
Comment 8 Maik Qualmann 2019-12-30 21:19:13 UTC
Unfortunately not fixed yet...

Maik
Comment 9 Maik Qualmann 2019-12-30 22:16:37 UTC
Git commit 439852f3396020728de20a43b7dd660fb7e05636 by Maik Qualmann.
Committed on 30/12/2019 at 22:15.
Pushed by mqualmann into branch 'master'.

next try to fix fullscreen translation

M  +3    -3    core/app/main/digikamui5.rc
M  +4    -3    core/libs/widgets/mainview/dxmlguiwindow.cpp
M  +2    -2    core/utilities/imageeditor/main/imageeditorui5.rc
M  +3    -3    core/utilities/import/main/importui5.rc
M  +3    -3    core/utilities/lighttable/lighttablewindowui5.rc
M  +3    -3    core/utilities/queuemanager/main/queuemgrwindowui5.rc

https://invent.kde.org/kde/digikam/commit/439852f3396020728de20a43b7dd660fb7e05636
Comment 10 Maik Qualmann 2019-12-30 22:23:50 UTC
Git commit 0cbbd5a6392c00c95876b0d08cd4cf4b35141e9d by Maik Qualmann.
Committed on 30/12/2019 at 22:23.
Pushed by mqualmann into branch 'master'.

Revert "next try to fix fullscreen translation"

M  +3    -3    core/app/main/digikamui5.rc
M  +3    -4    core/libs/widgets/mainview/dxmlguiwindow.cpp
M  +2    -2    core/utilities/imageeditor/main/imageeditorui5.rc
M  +3    -3    core/utilities/import/main/importui5.rc
M  +3    -3    core/utilities/lighttable/lighttablewindowui5.rc
M  +3    -3    core/utilities/queuemanager/main/queuemgrwindowui5.rc

https://invent.kde.org/kde/digikam/commit/0cbbd5a6392c00c95876b0d08cd4cf4b35141e9d
Comment 11 Maik Qualmann 2019-12-30 22:24:41 UTC
Note: KStandardAction automatically adds an additional "View" menu.

Maik
Comment 12 Alexandre Belz 2020-01-05 12:14:26 UTC
Still not resolved with Beta2.
Comment 13 caulier.gilles 2020-08-01 13:31:20 UTC
digiKam 7.0.0 stable release is now published and now available as FlatPak:

https://www.digikam.org/news/2020-07-19-7.0.0_release_announcement/

We need a fresh feedback on this file using this version.

Thanks in advance

Gilles Caulier
Comment 14 Alexandre Belz 2020-08-03 05:55:31 UTC
Hi @Gilles,
OK, I will re-test this week.
Comment 15 Maik Qualmann 2021-04-18 18:01:14 UTC
*** Bug 435884 has been marked as a duplicate of this bug. ***
Comment 16 Maik Qualmann 2021-05-10 18:10:08 UTC
Git commit 465c25dd9772b4d072b832c523ba4fffca4faf1f by Maik Qualmann.
Committed on 10/05/2021 at 18:08.
Pushed by mqualmann into branch 'master'.

load Qt translations and polish debug
Related: bug 436299
FIXED-IN: 7.3.0

M  +2    -2    NEWS
M  +2    -3    core/app/main/main.cpp
M  +2    -3    core/showfoto/main/main.cpp

https://invent.kde.org/graphics/digikam/commit/465c25dd9772b4d072b832c523ba4fffca4faf1f
Comment 17 caulier.gilles 2021-12-30 15:46:09 UTC
Fixed with works from bug #438701 for next 7.5.0 release

Gilles Caulier