| Summary: | Plasma tooltips draw shadows from the dialog svg instead of the tooltip svg | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] libplasma | Reporter: | bigangluvr |
| Component: | tooltips | Assignee: | Marco Martin <notmart> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | doncbugs, kde, kde, nate, plasma-bugs |
| Priority: | NOR | ||
| Version: | 5.65.0 | ||
| Target Milestone: | --- | ||
| Platform: | Manjaro | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/libplasma/-/commit/027c7d6af6ae7bb7884566753751e686bf054e18 | Version Fixed In: | 6.0 |
| Sentry Crash Report: | |||
| Attachments: | different tooltip style using dialog's shadows | ||
|
Description
bigangluvr
2019-12-27 10:30:50 UTC
Can confirm. It uses a shared DialogShadows instance which defaults to dialogs/background. The frameSvgItem used for the background sets the corret image path but still doesn't work for some reason... Seems to be fixed now. (In reply to Nate Graham from comment #2) > Seems to be fixed now. How did you verify this and why is there no link to any changes? Reproduced on latest neon unstable 5.23.80. Created attachment 142102 [details]
different tooltip style using dialog's shadows
A possibly relevant merge request was started @ https://invent.kde.org/plasma/libplasma/-/merge_requests/1017 Git commit 69fe0b04ce363d750961975140fb96df8cad1b20 by David Edmundson. Committed on 02/02/2024 at 16:02. Pushed by davidedmundson into branch 'master'. Use correct prefix SVG prefix for tooltips In various porting using the correct prefix for tooltips got lost. This patch restores that by adding an additional prefix argument to the constructor of PlasmaWindow and having a separate DialogShadows instance per SVG prefix. M +1 -1 src/declarativeimports/core/tooltipdialog.cpp M +2 -2 src/plasmaquick/appletpopup.cpp M +1 -1 src/plasmaquick/appletpopup.h M +3 -3 src/plasmaquick/dialog.cpp M +13 -10 src/plasmaquick/dialogshadows.cpp M +3 -3 src/plasmaquick/dialogshadows_p.h M +7 -5 src/plasmaquick/plasmawindow.cpp M +1 -1 src/plasmaquick/plasmawindow.h M +2 -2 src/plasmaquick/popupplasmawindow.cpp M +1 -1 src/plasmaquick/popupplasmawindow.h https://invent.kde.org/plasma/libplasma/-/commit/69fe0b04ce363d750961975140fb96df8cad1b20 Git commit 6d4a706af8b71a57d930e20f0f3d24c6c5d3354c by Nate Graham. Committed on 02/02/2024 at 17:13. Pushed by ngraham into branch 'master'. Revert "Use correct prefix SVG prefix for tooltips" This reverts commit 69fe0b04ce363d750961975140fb96df8cad1b20. It broke plasma-workspace compilation; we'll need to try again. M +1 -1 src/declarativeimports/core/tooltipdialog.cpp M +2 -2 src/plasmaquick/appletpopup.cpp M +1 -1 src/plasmaquick/appletpopup.h M +3 -3 src/plasmaquick/dialog.cpp M +10 -13 src/plasmaquick/dialogshadows.cpp M +3 -3 src/plasmaquick/dialogshadows_p.h M +5 -7 src/plasmaquick/plasmawindow.cpp M +1 -1 src/plasmaquick/plasmawindow.h M +2 -2 src/plasmaquick/popupplasmawindow.cpp M +1 -1 src/plasmaquick/popupplasmawindow.h https://invent.kde.org/plasma/libplasma/-/commit/6d4a706af8b71a57d930e20f0f3d24c6c5d3354c Had to revert since it broke plasma-workspace compilation. Re-opening. Git commit 3d8fea22963f81d8155299f5efd836e2ad854f2a by Nate Graham. Committed on 02/02/2024 at 18:55. Pushed by ngraham into branch 'master'. Reapply "Use correct prefix SVG prefix for tooltips" This reverts commit 6d4a706af8b71a57d930e20f0f3d24c6c5d3354c. The issue this caused in plasma-workspace is now fixed in https://invent.kde.org/plasma/plasma-workspace/-/commit/d057eb6a07dafef5d993474eb175c9f2bcc437a4 FIXED-IN: 6.0 M +1 -1 src/declarativeimports/core/tooltipdialog.cpp M +2 -2 src/plasmaquick/appletpopup.cpp M +1 -1 src/plasmaquick/appletpopup.h M +3 -3 src/plasmaquick/dialog.cpp M +13 -10 src/plasmaquick/dialogshadows.cpp M +3 -3 src/plasmaquick/dialogshadows_p.h M +7 -5 src/plasmaquick/plasmawindow.cpp M +1 -1 src/plasmaquick/plasmawindow.h M +2 -2 src/plasmaquick/popupplasmawindow.cpp M +1 -1 src/plasmaquick/popupplasmawindow.h https://invent.kde.org/plasma/libplasma/-/commit/3d8fea22963f81d8155299f5efd836e2ad854f2a Git commit 027c7d6af6ae7bb7884566753751e686bf054e18 by Nate Graham, on behalf of David Edmundson. Committed on 02/02/2024 at 19:22. Pushed by ngraham into branch 'Plasma/6.0'. Use correct prefix SVG prefix for tooltips In various porting using the correct prefix for tooltips got lost. This patch restores that by adding an additional prefix argument to the constructor of PlasmaWindow and having a separate DialogShadows instance per SVG prefix. (cherry picked from commit 69fe0b04ce363d750961975140fb96df8cad1b20) M +1 -1 src/declarativeimports/core/tooltipdialog.cpp M +2 -2 src/plasmaquick/appletpopup.cpp M +1 -1 src/plasmaquick/appletpopup.h M +3 -3 src/plasmaquick/dialog.cpp M +13 -10 src/plasmaquick/dialogshadows.cpp M +3 -3 src/plasmaquick/dialogshadows_p.h M +7 -5 src/plasmaquick/plasmawindow.cpp M +1 -1 src/plasmaquick/plasmawindow.h M +2 -2 src/plasmaquick/popupplasmawindow.cpp M +1 -1 src/plasmaquick/popupplasmawindow.h https://invent.kde.org/plasma/libplasma/-/commit/027c7d6af6ae7bb7884566753751e686bf054e18 |