| Summary: | Reorganize setting menus | ||
|---|---|---|---|
| Product: | [Unmaintained] lattedock | Reporter: | trmdi |
| Component: | application | Assignee: | Michail Vourlakos <mvourlakos> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version First Reported In: | git (master) | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/latte-dock/fe5dbf9f2b9657dd186e58eb55bc68af085d94d8 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
|
Description
trmdi
2019-12-26 15:19:10 UTC
That window is considered a Global Preferences Window, meaning options that alter settings for all docks/panels. As such, I find both tabs sufficient to be in there... (In reply to Michail Vourlakos from comment #1) > That window is considered a Global Preferences Window, meaning options that > alter settings for all docks/panels. > > As such, I find both tabs sufficient to be in there... I know both of them are for global settings, I just meant to reorganize them. When you click on Layout > Configure..., do you have a sense that it contains the Preference tab? it does but it is not accessed without user interaction (In reply to trmdi from comment #2) > (In reply to Michail Vourlakos from comment #1) > > That window is considered a Global Preferences Window, meaning options that > > alter settings for all docks/panels. > > > > As such, I find both tabs sufficient to be in there... > > I know both of them are for global settings, I just meant to reorganize them. > When you click on Layout > Configure..., do you have a sense that it > contains the Preference tab? For example, why does "Autostart" option belong to the Layout > Configure ? Those 2 things are completely unrelated. Latte Global Preferences tab is hidden because is not used often, having different ways to access it, I consider it normal. (In reply to Michail Vourlakos from comment #1) > That window is considered a Global Preferences Window, meaning options that > alter settings for all docks/panels. > > As such, I find both tabs sufficient to be in there... Ok, but I still prefer to move Layout > Configure to the top level and rename it to e.g. "Latte global settings..." Because a Configure insides the Layout give me a feel that it's only used for Configuring Layouts. Git commit fe5dbf9f2b9657dd186e58eb55bc68af085d94d8 by Tranter Madi.
Committed on 27/12/2019 at 16:41.
Pushed by trmdi into branch 'master'.
Improve context menu
Summary:
- Add `Configure Latte Global Settings...` because it's too hidden in Layout > Configure and does not relate to the Layout menu.
- Insert a new `Separator` to separate between Global settings and View settings (see screenshot)
- Rename `Panel/Dock Settings` to `Edit Panel/Dock` (Verb + Noun)
- Rename `Layout > Configure...` to `Layout > Manage Layouts` (Verb + Noun)
Menu Items Order:
a. -separator-
b. Layouts->
c. Configure Application...
e. -separator-
f. Add Widgets...
g. Edit Dock...
h. -separator- [only for Tasks plasmoid]
i. Close... [only for Tasks plasmoid]
Test Plan:
Before:
{F7844554}
After:
a. context menu of applets
{F7845184}
b. context menu of a task that hasn't/has one window shown
{F7844944}
{F7845185}
c. context menu of Latte Tasks plasmoid when used on the desktop
{F7845186}
{F7845187}
Reviewers: #latte_dock, #vdg, mvourlakos
Reviewed By: #latte_dock, mvourlakos
Subscribers: ngraham, ndavis, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26238
M +4 -6 app/layouts/manager.cpp
M +1 -1 app/layouts/manager.h
M +6 -1 app/settings/settingsdialog.cpp
M +1 -0 app/settings/settingsdialog.h
M +1 -1 app/shortcuts/globalshortcuts.cpp
M +22 -5 containmentactions/contextmenu/menu.cpp
M +2 -0 containmentactions/contextmenu/menu.h
M +18 -4 plasmoid/package/contents/ui/ContextMenu.qml
https://commits.kde.org/latte-dock/fe5dbf9f2b9657dd186e58eb55bc68af085d94d8
|