Bug 415549

Summary: "Open Folder in tabs" gone
Product: [Applications] konsole Reporter: peter.snauwaert
Component: bookmarkAssignee: Konsole Bugs <konsole-bugs-null>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version First Reported In: 19.12.0   
Target Milestone: ---   
Platform: openSUSE   
OS: Linux   
Latest Commit: https://commits.kde.org/konsole/5b5ad9f93eb7f2fd39a2191a7be15572dcdaa2ad Version Fixed/Implemented In: 19.12.1
Sentry Crash Report:

Description peter.snauwaert 2019-12-25 10:55:45 UTC 
SUMMARY
I use the "Open folder in tabs" from the bookmarks menu quite often. Apparently I can still create and edit folders and bookmark entries from Konsole but since a couple of weeks the "Open Folder in Tabs" seems to have disappeared. I really miss this feature.


STEPS TO REPRODUCE
1. Open couple of tabs in Konsole 
2. Save tabs as bookmarks in a folder
3. Try to open them from the bookmarks menu

OBSERVED RESULT
The entry that read something like "Open folder in tabs" is not there anymore.

EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: Opensuse Tumbleweed / 5.17.4
(available in About System)
KDE Plasma Version: 5.17.4
KDE Frameworks Version: 5.65.0
Qt Version: 5.13.1

ADDITIONAL INFORMATION
Comment 1 Kurt Hindenburg 2019-12-27 04:13:04 UTC 
Yea, it is in 19.08 but not later.  The only change to bookmarks was to disallow duplicate entires.  I'll research.
Comment 2 Kurt Hindenburg 2019-12-27 04:52:18 UTC 
Git commit 00c20b240d0b957da7cfc8444ab794e54840ad08 by Kurt Hindenburg.
Committed on 27/12/2019 at 04:51.
Pushed by hindenburg into branch 'master'.

Revert supportTabs() removal to fix bookmenu issue

This reverts  0995c1dc95bb0df2a04aa84e1034044448ab542e; it is needed
to allow KBookMarks to know we supports tabs and thus show 'Open
folder in tabs' menu item.

FIXED-IN: 19.12.1

M  +5    -0    src/BookmarkHandler.cpp
M  +1    -0    src/BookmarkHandler.h

https://invent.kde.org/kde/konsole/commit/00c20b240d0b957da7cfc8444ab794e54840ad08
Comment 3 Kurt Hindenburg 2019-12-27 04:52:21 UTC 
Git commit 00c20b240d0b957da7cfc8444ab794e54840ad08 by Kurt Hindenburg.
Committed on 27/12/2019 at 04:51.
Pushed by scmsync into branch 'master'.

Revert supportTabs() removal to fix bookmenu issue

This reverts  0995c1dc95bb0df2a04aa84e1034044448ab542e; it is needed
to allow KBookMarks to know we supports tabs and thus show 'Open
folder in tabs' menu item.

FIXED-IN: 19.12.1

M  +5    -0    src/BookmarkHandler.cpp
M  +1    -0    src/BookmarkHandler.h

https://commits.kde.org/konsole/00c20b240d0b957da7cfc8444ab794e54840ad08
Comment 4 Kurt Hindenburg 2019-12-27 04:56:05 UTC 
Git commit 5b5ad9f93eb7f2fd39a2191a7be15572dcdaa2ad by Kurt Hindenburg.
Committed on 27/12/2019 at 04:55.
Pushed by hindenburg into branch 'release/19.12'.

Revert supportTabs() removal to fix bookmenu issue

This reverts  0995c1dc95bb0df2a04aa84e1034044448ab542e; it is needed
to allow KBookMarks to know we supports tabs and thus show 'Open
folder in tabs' menu item.

FIXED-IN: 19.12.1

M  +5    -0    src/BookmarkHandler.cpp
M  +1    -0    src/BookmarkHandler.h

https://invent.kde.org/kde/konsole/commit/5b5ad9f93eb7f2fd39a2191a7be15572dcdaa2ad
Comment 5 Kurt Hindenburg 2019-12-27 04:56:08 UTC 
Git commit 5b5ad9f93eb7f2fd39a2191a7be15572dcdaa2ad by Kurt Hindenburg.
Committed on 27/12/2019 at 04:55.
Pushed by scmsync into branch 'release/19.12'.

Revert supportTabs() removal to fix bookmenu issue

This reverts  0995c1dc95bb0df2a04aa84e1034044448ab542e; it is needed
to allow KBookMarks to know we supports tabs and thus show 'Open
folder in tabs' menu item.

FIXED-IN: 19.12.1

M  +5    -0    src/BookmarkHandler.cpp
M  +1    -0    src/BookmarkHandler.h

https://commits.kde.org/konsole/5b5ad9f93eb7f2fd39a2191a7be15572dcdaa2ad