Bug 415158

Summary:	icotool does not produce .ico file
Product:	[Developer tools] Craft	Reporter:	Alexander Potashev <aspotashev>
Component:	Blueprints	Assignee:	Hannah von Reth <vonreth>
Status:	RESOLVED FIXED
Severity:	normal	CC:	kde-windows
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Linux
Latest Commit:		Version Fixed In:	305c53cba14a43fb4ef2e86a603c86b7887031c8

Description Alexander Potashev 2019-12-13 22:29:09 UTC

SUMMARY
icotool does not produce .ico file.

The following command (which is part of the ktimetracker build procedure with "craft ktimetracker") does not produce the ICO file in the destination path:

cmd.exe /C "cd /D C:\CraftRoot\build\_\5ebfb487\ktimetracker\icons\app && C:\CraftRoot\dev-utils\bin\ic
otool.exe -c -o C:/CraftRoot/build/_/18046bba/RelWithDebInfo-master/icons/app/ktimetracker_app_icon_SRCS.ico C:/CraftRoo
t/build/_/5ebfb487/ktimetracker/icons/app/16-apps-ktimetracker.png C:/CraftRoot/build/_/5ebfb487/ktimetracker/icons/app/
32-apps-ktimetracker.png C:/CraftRoot/build/_/5ebfb487/ktimetracker/icons/app/48-apps-ktimetracker.png C:/CraftRoot/buil
d/_/5ebfb487/ktimetracker/icons/app/64-apps-ktimetracker.png C:/CraftRoot/build/_/5ebfb487/ktimetracker/icons/app/128-ap
ps-ktimetracker.png"

STEPS TO REPRODUCE
1. 
2. 
3. 

OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 10
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION

Comment 1 Alexander Potashev 2019-12-13 22:33:26 UTC

Guilty commit: https://cgit.kde.org/craft-blueprints-kde.git/commit/?id=3e08b58a185895a4a8d0ecfb84b3def2c37cacbe

Worked the problem around locally by dropping out the latest 4 commits including the above mentioned commit.

Comment 2 Alexander Potashev 2019-12-13 22:33:44 UTC

compiler: MSVC 2019

Comment 3 Alexander Potashev 2019-12-14 15:46:53 UTC

Another proof of icotool not working: https://binary-factory.kde.org/job/KTimeTracker_Nightly_win64/2/console

Comment 4 Hannah von Reth 2019-12-15 16:29:53 UTC

Fixed in https://cgit.kde.org/craft-blueprints-kde.git/commit/?id=305c53cba14a43fb4ef2e86a603c86b7887031c8 

You might need to call craft -i craft