| Summary: | ctrl+alt+(left|right) broken in yakuake | ||
|---|---|---|---|
| Product: | [Applications] konsole | Reporter: | Vadim Fint <mocksoul> |
| Component: | kpart | Assignee: | Konsole Developer <konsole-devel> |
| Status: | RESOLVED WORKSFORME | ||
| Severity: | normal | CC: | justin.zobel, tcanabrava |
| Priority: | NOR | ||
| Version: | 19.12.0 | ||
| Target Milestone: | --- | ||
| Platform: | Gentoo Packages | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
patch (not fix, just revert)
patch #2 (just disable move-tab-to-(left|right) actions) attachment-5576-0.html |
||
|
Description
Vadim Fint
2019-12-13 13:41:10 UTC
Created attachment 124463 [details]
patch (not fix, just revert)
the revert breaks konsole so I can't accept it, let me take a look on it to see if I understand why my patch breaks yakuake. The one thing that I see is that I added those lines on the patch:
action = new QAction(i18nc("@action Shortcut entry", "Move tab to the left"), this);
collection->addAction(QStringLiteral("move-tab-to-left"), action);
collection->setDefaultShortcut(action, Qt::CTRL + Qt::ALT + Qt::Key_Left);
That handle focusing tab on the left / on the right. You told me on your bug description that *even if* you disabled those shortcuts, yakuake couldn't still see the keystrokes, is that correct?
If so, can you test by just disabling the focus tab left / right and check if it works in yakuake?
I would really like to implement the hide / show feature of yakuake in konsole so we wouldn't need to reimplement most of the things I did here on the split handling.
Created attachment 124465 [details] patch #2 (just disable move-tab-to-(left|right) actions) > You told me on your bug description that *even if* you disabled those shortcuts, yakuake couldn't still see the keystrokes, is that correct? yes, correct. I see same options in yakuake shortcut settings, but disabling them does not change anything. I tried just to disable things you told and it works fine! (smaller patch attached). > I would really like to implement the hide / show feature of yakuake in konsole so we wouldn't need to reimplement most of the things I did here on the split handling. Yeah, this is not a first time something works properly in konsole, but fails in yakuake.. Created attachment 124472 [details] attachment-5576-0.html One of the issues is that yakuake provides a different set of tabs than konsole, and the same shortcut could make things misbehave? I'l talking with the yakuake dev. On Fri, Dec 13, 2019 at 2:29 PM Vadim Fint <bugzilla_noreply@kde.org> wrote: > https://bugs.kde.org/show_bug.cgi?id=415135 > > Vadim Fint <mocksoul@gmail.com> changed: > > What |Removed |Added > > ---------------------------------------------------------------------------- > Attachment #124463 [details]|0 |1 > is obsolete| | > > --- Comment #4 from Vadim Fint <mocksoul@gmail.com> --- > Created attachment 124465 [details] > --> https://bugs.kde.org/attachment.cgi?id=124465&action=edit > patch #2 (just disable move-tab-to-(left|right) actions) > > > You told me on your bug description that *even if* you disabled those > shortcuts, yakuake couldn't still see the keystrokes, is that correct? > > yes, correct. I see same options in yakuake shortcut settings, but > disabling > them does not change anything. > > I tried just to disable things you told and it works fine! (smaller patch > attached). > > > I would really like to implement the hide / show feature of yakuake in > konsole so we wouldn't need to reimplement most of the things I did here on > the split handling. > > Yeah, this is not a first time something works properly in konsole, but > fails > in yakuake.. > > -- > You are receiving this mail because: > You are on the CC list for the bug. (In reply to tcanabrava from comment #5) > Created attachment 124472 [details] > attachment-5576-0.html > > One of the issues is that yakuake provides a different set of tabs than > konsole, and the same shortcut could make things misbehave? > I'l talking with the yakuake dev. > > On Fri, Dec 13, 2019 at 2:29 PM Vadim Fint <bugzilla_noreply@kde.org> wrote: > > > https://bugs.kde.org/show_bug.cgi?id=415135 > > > > Vadim Fint <mocksoul@gmail.com> changed: > > > > What |Removed |Added > > > > ---------------------------------------------------------------------------- > > Attachment #124463 [details]|0 |1 > > is obsolete| | > > > > --- Comment #4 from Vadim Fint <mocksoul@gmail.com> --- > > Created attachment 124465 [details] > > --> https://bugs.kde.org/attachment.cgi?id=124465&action=edit > > patch #2 (just disable move-tab-to-(left|right) actions) > > > > > You told me on your bug description that *even if* you disabled those > > shortcuts, yakuake couldn't still see the keystrokes, is that correct? > > > > yes, correct. I see same options in yakuake shortcut settings, but > > disabling > > them does not change anything. > > > > I tried just to disable things you told and it works fine! (smaller patch > > attached). > > > > > I would really like to implement the hide / show feature of yakuake in > > konsole so we wouldn't need to reimplement most of the things I did here on > > the split handling. > > > > Yeah, this is not a first time something works properly in konsole, but > > fails > > in yakuake.. > > > > -- > > You are receiving this mail because: > > You are on the CC list for the bug. Tomaz can you please confirm this has been merged and that this issue can be resolved, thanks. Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging If you have already provided the requested information, please mark the bug as REPORTED so that the KDE team knows that the bug is ready to be confirmed. Thank you for helping us make KDE software even better for everyone! This bug has been in NEEDSINFO status with no change for at least 30 days. The bug is now closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging Thank you for helping us make KDE software even better for everyone! |