Bug 415074

Summary: Collapsible drawer handle is missing [Commit 4a1b1206]
Product: [Frameworks and Libraries] frameworks-kirigami Reporter: Janet Blackquill <uhhadd>
Component: generalAssignee: Marco Martin <notmart>
Status: RESOLVED FIXED    
Severity: major CC: nate
Priority: NOR    
Version First Reported In: Master   
Target Milestone: Not decided   
Platform: Other   
OS: Linux   
Latest Commit: https://commits.kde.org/kirigami/028a604e6f8fdcf1e4d0c4363a3a543f41b8398e Version Fixed/Implemented In: 5.66
Sentry Crash Report:
Attachments: Attachment 1

Description Janet Blackquill 2019-12-11 22:59:51 UTC 
Created attachment 124442 [details]
Attachment 1 [details]

SUMMARY
Ikona uses a collapsible drawer to provide access to functionality while preserving maximum canvas size. However, the collapsible drawer's handle has gone missing after changes in Kirigami, making the app effectively unusable as core functionality cannot be accessed, such as opening icons.

STEPS TO REPRODUCE
1. Get Ikona
2. Open

OBSERVED RESULT
Attachment 1 [details]

EXPECTED RESULT
https://invent.kde.org/kde/ikona/blob/master/screen.png (Outdated, but drawer handle should still exist in the latest version.)

SOFTWARE/OS VERSIONS
Operating System: openSUSE Tumbleweed 20191204
KDE Plasma Version: 5.17.80
KDE Frameworks Version: 5.65.0
Qt Version: 5.13.1
Kernel Version: 5.3.11-1-default
OS Type: 64-bit
Processors: 8 × Intel® Xeon® CPU X5570 @ 2.93GHz
Memory: 11.7 GiB of RAM
Comment 1 Marco Martin 2019-12-12 11:44:29 UTC 
Git commit 028a604e6f8fdcf1e4d0c4363a3a543f41b8398e by Marco Martin.
Committed on 12/12/2019 at 11:43.
Pushed by mart into branch 'master'.

reintroduce the collapse button

M  +1    -1    src/controls/ApplicationWindow.qml
M  +15   -0    src/controls/GlobalDrawer.qml

https://commits.kde.org/kirigami/028a604e6f8fdcf1e4d0c4363a3a543f41b8398e
Comment 2 Marco Martin 2019-12-12 11:45:09 UTC 
Reintroduced the collapse button: after discussion with Nate, we decided to put it at the bottom instead