Bug 415049

Summary:	SDDM theme: missing an arrow icon in the Desktop Session button after QQC2 port
Product:	[Plasma] plasmashell	Reporter:	Filip Fila <filipfila.kde>
Component:	Theme - Breeze	Assignee:	visual-design
Status:	RESOLVED FIXED
Severity:	minor	CC:	fabian, nate, plasma-bugs
Priority:	NOR
Version:	master
Target Milestone:	1.0
Platform:	Other
OS:	Linux
Latest Commit:	https://cgit.kde.org/plasma-workspace.git/commit/?id=86570a22dfc7a0b45ac01b22d4f1f17937cd394c	Version Fixed In:

Description Filip Fila 2019-12-11 12:55:45 UTC

SUMMARY
The downside of PC3 ToolButton, which we now use for the Desktop Session button, is that there is no menu property and consequently no arrow icon is drawn anymore.

"There is nothing in QQC2::Button to add a menu

If we want that it would have to be a custom button subclass, rather than something we support in the style." - d_ed

"Or as a simple hack for this case, adding "▾" to the button's label." - fvogt 

OBSERVED RESULT
No arrow icon.

EXPECTED RESULT
Used to look like this: https://openqa.opensuse.org/tests/1105226#step/start_wayland_plasma5/21

SOFTWARE/OS VERSIONS
KDE Plasma Version: pre 5.18
KDE Frameworks Version: pre 5.66

Comment 1 Filip Fila 2019-12-11 12:57:31 UTC

Adding the arrow to the label's text could work, but I just tried it and it ends up looking really small: https://i.imgur.com/Od9CZ2a.png

Comment 2 Fabian Vogt 2019-12-11 13:11:51 UTC

Maybe "▼" then?

Unfortunately that would depend on the chosen font rather than the chosen theme...

Comment 3 Filip Fila 2019-12-11 20:29:56 UTC

That doesn't look too bad: https://i.imgur.com/1AC2Qai.png

If only it could be titled up a bit.

Comment 4 Filip Fila 2019-12-13 10:25:25 UTC

The cause has been reverted, as well as the complementary patch: https://cgit.kde.org/plasma-workspace.git/commit/?id=3b8c0f0ababd98cc53460063391903a925a22749