Bug 415000

Summary: [PC3 ProgressBar] barSvg is not defined
Product: [Frameworks and Libraries] frameworks-qqc2-desktop-style Reporter: Filip Fila <filipfila.kde>
Component: generalAssignee: Marco Martin <notmart>
Status: RESOLVED FIXED    
Severity: normal CC: kde
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: https://cgit.kde.org/plasma-framework.git/commit/?id=2649878108dcae613b03f880faea8fe30d578957 Version Fixed/Implemented In:
Sentry Crash Report:

Description Filip Fila 2019-12-09 20:59:13 UTC 
SUMMARY

Lines 74 and 76 reference "barSvg" but it's not defined anywhere: https://github.com/KDE/plasma-framework/blob/master/src/declarativeimports/plasmacomponents3/ProgressBar.qml#L74

When using the progressbar3.qml test in the repo an error occurs: barSvg is not defined.

In PC2 the id was assigned to the Svg: https://github.com/KDE/plasma-framework/blob/master/src/declarativeimports/plasmastyle/ProgressBarStyle.qml#L35

STEPS TO REPRODUCE
1. observe output of progressbar3.qml test in repo

OBSERVED RESULT
error

EXPECTED RESULT
no error

SOFTWARE/OS VERSIONS
Master on Dec 9th 2019
Comment 1 Filip Fila 2019-12-09 21:47:37 UTC 
As for solutions, just adding the id won't work since 'FrameSvgItem' knows nothing about 'elementSize'.

I did manage to add this to 'FrameSvgItem' from 'Svg' and then after adding the id the error goes away, but I don't know if that's the right approach (vs. coding the implicitHeight code differently on the QML side).
Comment 2 David Edmundson 2019-12-10 18:25:15 UTC 
Real question is, what useful thing is this addressing?
Comment 3 Filip Fila 2019-12-20 01:17:43 UTC 
I'm not sure, but Aleix removed the code anyway.