Bug 414929

Summary: Buttons on sddm greeter invisible
Product: [Frameworks and Libraries] libplasma Reporter: Fabian Vogt <fabian>
Component: componentsAssignee: Marco Martin <notmart>
Status: RESOLVED FIXED    
Severity: major CC: bugseforuns, filipfila.kde
Priority: NOR    
Version First Reported In: 5.64.0   
Target Milestone: ---   
Platform: openSUSE   
OS: Linux   
Latest Commit: https://commits.kde.org/plasma-framework/e4e1613b0fe741aa6330810560bedf71b25e0e4c Version Fixed/Implemented In: 5.66
Sentry Crash Report:

Description Fabian Vogt 2019-12-07 17:15:38 UTC 
Found by openQA: https://openqa.opensuse.org/tests/1106024#step/start_wayland_plasma5/21

The "Desktop Session: Plasma" label next to "Virtual Keyboard" in the bottom left is the same color as the background, so practically invisible.
Switching back to PlasmaComponents 2.0 (like "Virtual Keyboard" already is) makes it appear properly again.
Comment 1 Filip Fila 2019-12-07 21:47:54 UTC 
I have a patch to fix that: https://phabricator.kde.org/D25699

Would appreciate your review.
Comment 2 Filip Fila 2019-12-11 12:50:21 UTC 
Git commit e4e1613b0fe741aa6330810560bedf71b25e0e4c by Filip Fila.
Committed on 11/12/2019 at 12:50.
Pushed by filipf into branch 'master'.

[PC3 ToolButton] Have the label take into account complementary color schemes

Summary:
We've ported the SDDM theme to PC3 and now have black labels in PC3 ToolButtons (keyboard and session button).

The SDDM theme uses a complementary color scheme, which is something the PC2 ToolButton respects and turns the labels white.

Therefore I just copy pasted PC2's label color code to its PC3 counterpart.
FIXED-IN: 5.66

Test Plan:
```
import QtQuick 2.13
import org.kde.plasma.components 3.0 as PlasmaComponents
import org.kde.plasma.core 2.0 as PlasmaCore

PlasmaCore.ColorScope {
    colorGroup: PlasmaCore.Theme.ComplementaryColorGroup

    Rectangle {
        height: 80
        width: 100
        color: "red"

        PlasmaComponents.ToolButton{
            anchors.fill: parent
            text: "sup"
        }
    }
}
```

The label was white instead of black.

Reviewers: #plasma, ngraham, davidedmundson

Reviewed By: #plasma, ngraham, davidedmundson

Subscribers: mart, davidedmundson, fvogt, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D25699

M  +8    -1    src/declarativeimports/plasmacomponents3/ToolButton.qml

https://commits.kde.org/plasma-framework/e4e1613b0fe741aa6330810560bedf71b25e0e4c