Bug 414795

Summary:	calligra-3.1.0: karbon - fails to build with poppler >= 0.83.0
Product:	[Applications] karbon	Reporter:	Timo Gurr <timo.gurr>
Component:	general	Assignee:	Jan Hambrecht <jaham>
Status:	REPORTED ---
Severity:	normal
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	calligra-3.1.0-Fix-build-with-poppler-0.83.patch

Description Timo Gurr 2019-12-03 13:16:17 UTC

New compile failures with poppler 0.83.0, with the patch applied from https://bugs.kde.org/show_bug.cgi?id=414751:

/var/tmp/paludis/build/app-office-calligra-3.1.0-r3/work/calligra-3.1.0/filters/karbon/pdf/SvgOutputDev.cpp: In member function 'virtual void SvgOutputDev::stroke(GfxState*)':
/var/tmp/paludis/build/app-office-calligra-3.1.0-r3/work/calligra-3.1.0/filters/karbon/pdf/SvgOutputDev.cpp:144:46: error: invalid conversion from 'const GfxPath*' to 'GfxPath*' [-fpermissive]
  144 |     QString path = convertPath(state->getPath());
      |                                ~~~~~~~~~~~~~~^~
      |                                              |
      |                                              const GfxPath*
In file included from /var/tmp/paludis/build/app-office-calligra-3.1.0-r3/work/calligra-3.1.0/filters/karbon/pdf/SvgOutputDev.cpp:20:
/var/tmp/paludis/build/app-office-calligra-3.1.0-r3/work/calligra-3.1.0/filters/karbon/pdf/SvgOutputDev.h:86:34: note:   initializing argument 1 of 'QString SvgOutputDev::convertPath(GfxPath*)'
   86 |     QString convertPath(GfxPath *path);
      |                         ~~~~~~~~~^~~~
/var/tmp/paludis/build/app-office-calligra-3.1.0-r3/work/calligra-3.1.0/filters/karbon/pdf/SvgOutputDev.cpp: In member function 'virtual void SvgOutputDev::fill(GfxState*)':
/var/tmp/paludis/build/app-office-calligra-3.1.0-r3/work/calligra-3.1.0/filters/karbon/pdf/SvgOutputDev.cpp:155:46: error: invalid conversion from 'const GfxPath*' to 'GfxPath*' [-fpermissive]
  155 |     QString path = convertPath(state->getPath());
      |                                ~~~~~~~~~~~~~~^~
      |                                              |
      |                                              const GfxPath*
In file included from /var/tmp/paludis/build/app-office-calligra-3.1.0-r3/work/calligra-3.1.0/filters/karbon/pdf/SvgOutputDev.cpp:20:
/var/tmp/paludis/build/app-office-calligra-3.1.0-r3/work/calligra-3.1.0/filters/karbon/pdf/SvgOutputDev.h:86:34: note:   initializing argument 1 of 'QString SvgOutputDev::convertPath(GfxPath*)'
   86 |     QString convertPath(GfxPath *path);
      |                         ~~~~~~~~~^~~~
/var/tmp/paludis/build/app-office-calligra-3.1.0-r3/work/calligra-3.1.0/filters/karbon/pdf/SvgOutputDev.cpp: In member function 'virtual void SvgOutputDev::eoFill(GfxState*)':
/var/tmp/paludis/build/app-office-calligra-3.1.0-r3/work/calligra-3.1.0/filters/karbon/pdf/SvgOutputDev.cpp:166:46: error: invalid conversion from 'const GfxPath*' to 'GfxPath*' [-fpermissive]
  166 |     QString path = convertPath(state->getPath());
      |                                ~~~~~~~~~~~~~~^~
      |                                              |
      |                                              const GfxPath*
In file included from /var/tmp/paludis/build/app-office-calligra-3.1.0-r3/work/calligra-3.1.0/filters/karbon/pdf/SvgOutputDev.cpp:20:
/var/tmp/paludis/build/app-office-calligra-3.1.0-r3/work/calligra-3.1.0/filters/karbon/pdf/SvgOutputDev.h:86:34: note:   initializing argument 1 of 'QString SvgOutputDev::convertPath(GfxPath*)'
   86 |     QString convertPath(GfxPath *path);
      |                         ~~~~~~~~~^~~~

Complete build log attached.

Comment 1 Timo Gurr 2019-12-03 13:17:08 UTC

Edit, complete build log was too big to attach.

Comment 2 Timo Gurr 2019-12-04 12:55:21 UTC

Created attachment 124309 [details]
calligra-3.1.0-Fix-build-with-poppler-0.83.patch

Attached patch contrains the required changes between poppler 0.82 -> 0.83