Bug 414739

Darn, I know we've seen and fixed this before. :/ Cannot reproduce with git master. David, is this one of the ones that's already fixed in 19.12?

If I understand it correctly this special case is not fixed:
- Quit after saving is checked
- You save, spectacle closes but the process is running because we show the notification
- Hit print screen again, runnning process creates a new window
- Note that quit after save is still checked
- Notification times out, because quit after save is checked spectacle terminates itself

Git commit dec0e6cef23ac35754aa537db6d7ace42b23ca2a by Méven Car.
Committed on 05/06/2020 at 09:10.
Pushed by meven into branch 'master'.

Refactor Spectacle to run in single instance mode with KDBusService::Unique

Summary:
Since Spectacle got DBus activation support in 09cd11881d828da35c46c48da79f2d988e6a78cc, it has been run in multiple instance mode.
But it has been shaddowed by using qbus ee862d161a480408338d00b8826c915f7a97575c in the desktop file to mimic singleton behavior.

This refactors Spectacle to run in true single instance mode using KDBusService::Unique.
This is to allow Spectacle to have its executable in its Exec desktop Entry, to allow KWin to match the executable to the service file, itself to allow screenshots under Wayland without intermediate click.

The listed bugs are fixed incidently except for 414739 where a simple fix was added in screenShotUpdated.
Related: bug 420477, bug 412186

Test Plan:
Start spectacle, alternatively, from shortcut, command line.
Take screenshots, from alternative ways.

There is always at most one Spectacle window unless launched with `--new-instance`.

Reviewers: davidre, ngraham, bport, davidedmundson, apol

Reviewed By: davidre

Subscribers: broulik, anthonyfieroni, #spectacle

Tags: #spectacle

Differential Revision: https://phabricator.kde.org/D29487

M  +2    -2    desktop/org.kde.spectacle.desktop.cmake
M  +30   -89   src/Main.cpp
M  +170  -105  src/SpectacleCore.cpp
M  +8    -10   src/SpectacleCore.h
M  +5    -10   src/SpectacleDBusAdapter.cpp
M  +0    -31   src/SpectacleDBusAdapter.h

https://invent.kde.org/graphics/spectacle/commit/dec0e6cef23ac35754aa537db6d7ace42b23ca2a

This bug is still reproducible on neon unstable.

Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.19.80
KDE Frameworks Version: 5.72.0
Qt Version: 5.14.2

I'm using Spectacle 21.08.2 on Arch and I can confirm this has been fixed.

Though a little friction in terms migration happened in the Custom Shortcuts. There is a Custom Shortcuts -> Spectacle -> Rectangular region to clipboard in my config, which I think comes with Plasma itself (?), was still using `spectacle -bcr`. I updated it to `spectacle -bcri` to stop new Spectacle windows from being killed by notifications of this shortcut.

Thanks everyone for the help.

I can reproduce with Spectacle 21.08.2 on Arch Linux, at least on Wayland.

1. open Spectacle
2. make sure 'Full screen' mode is selected in 'Area' combobox
3. save the screenshot (Plasma displays a notification)
4. reopen Spectacle by pressing printscreen key
5. wait the notification to disappear

Result: Spectacle closes when the notification disappears.

@Patrick Is it possible that you've got an old copy of the .desktop file in e.g. ~/.local/share/applications?

(In reply to Frederick Zhang from comment #7)
> @Patrick Is it possible that you've got an old copy of the .desktop file in
> e.g. ~/.local/share/applications?

I don't think this bug is related to .desktop file because I can also reproduce on another system (neon unstable).
Al least on neon unstable, there is no .desktop file for Spectacle in ~/.local/share/applications.