Bug 414690

Summary:	Show in Timeline should be by default disabled for masks
Product:	[Applications] krita	Reporter:	Tiar <tamtamy.tymona>
Component:	Animation	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	ahab.greybeard
Priority:	NOR
Version First Reported In:	git master (please specify the git hash!)
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/kde/krita/commit/930bdbeedc5941e9796e14551b94aa3e363b2069	Version Fixed In:
Sentry Crash Report:

Description Tiar 2019-11-30 15:00:48 UTC

SUMMARY
Right now all layers are by default visible on the Timeline. I would prefer that at least masks should have it disabled by default.

STEPS TO REPRODUCE
1. Create a layer.
2. Add frames.
3. Switch to animation workspace.
4. Add a mask.

OBSERVED RESULT
Mask is visible on the Timeline.

EXPECTED RESULT
Mask should not be visible on the Timeline.

ADDITIONAL INFORMATION
Related, but not the same: bug 413805
Maybe in this case a toggle "Hide masks" would be desirable?


SOFTWARE/OS VERSIONS
Krita

 Version: 4.3.0-prealpha (git 2d4ae8c)
 Languages: pl
 Hidpi: true

Qt

  Version (compiled): 5.11.1
  Version (loaded): 5.11.1

OS Information

  Build ABI: x86_64-little_endian-lp64
  Build CPU: x86_64
  CPU: x86_64
  Kernel Type: linux
  Kernel Version: 5.3.7-050307-generic
  Pretty Productname: Linux Mint 19.2
  Product Type: linuxmint
  Product Version: 19.2

OpenGL Info
 
  Vendor:  "Intel Open Source Technology Center" 
  Renderer:  "Mesa DRI Intel(R) Iris(R) Plus Graphics (Ice Lake 8x8 GT2) " 
  Version:  "3.0 Mesa 19.0.8" 
  Shading language:  "1.30" 
  Requested format:  QSurfaceFormat(version 3.0, options QFlags<QSurfaceFormat::FormatOption>(DeprecatedFunctions), depthBufferSize 24, redBufferSize 8, greenBufferSize 8, blueBufferSize 8, alphaBufferSize 8, stencilBufferSize 8, samples -1, swapBehavior QSurfaceFormat::SwapBehavior(DoubleBuffer), swapInterval 0, colorSpace QSurfaceFormat::ColorSpace(DefaultColorSpace), profile  QSurfaceFormat::OpenGLContextProfile(CompatibilityProfile)) 
  Current format:    QSurfaceFormat(version 3.0, options QFlags<QSurfaceFormat::FormatOption>(DeprecatedFunctions), depthBufferSize 24, redBufferSize 8, greenBufferSize 8, blueBufferSize 8, alphaBufferSize 8, stencilBufferSize 8, samples -1, swapBehavior QSurfaceFormat::SwapBehavior(DoubleBuffer), swapInterval 0, colorSpace QSurfaceFormat::ColorSpace(DefaultColorSpace), profile  QSurfaceFormat::OpenGLContextProfile(NoProfile)) 
     Version: 3.0
     Supports deprecated functions true 
     is OpenGL ES: false 

QPA OpenGL Detection Info 
  supportsDesktopGL: true 
  supportsOpenGLES: true 
  isQtPreferOpenGLES: false 

Hardware Information

  GPU Acceleration: auto
  Memory: 15633 Mb
  Number of Cores: 8
  Swap Location: /tmp

Current Settings

	Current Swap Location: /tmp
	Undo Enabled: 1
	Undo Stack Limit: 30
	Use OpenGL: 1
	Use OpenGL Texture Buffer: 1
	Use AMD Vectorization Workaround: 0
	Canvas State: OPENGL_SUCCESS
	Autosave Interval: 180
	Use Backup Files: 1
	Number of Backups Kept: 1
	Backup File Suffix: ~
	Backup Location: Same Folder as the File
	Use Win8 Pointer Input: 0
	Use RightMiddleTabletButton Workaround: 0
	Levels of Detail Enabled: 1
	Use Zip64: 0

Comment 1 Ahab Greybeard 2019-11-30 17:52:37 UTC

I'd like a toggle that does all enabled/disabled by default :)
If I want to work with an animated mask then I'd want it to have the same behaviour as other layers.
Could there be a hierarchy of toggles for different types of layers?

It would be important to make sure that this is only for newly created layers of course.

Comment 2 Emmet O'Neill 2020-04-08 20:21:06 UTC

Git commit a1cd8d74b1a7e2b77010adae312b25168f6e9459 by Emmet O'Neill.
Committed on 08/04/2020 at 19:54.
Pushed by emmetoneill into branch 'master'.

Added user setting for autopinning layers to timeline.

Currently this setting only applies to paint layers,
so other types of nodes will not be autopinned at all.
Related: bug 413805

M  +14   -14   libs/image/kis_base_node.cpp
M  +8    -1    libs/image/kis_base_node.h
M  +5    -5    libs/image/kis_layer_utils.cpp
M  +3    -3    libs/libkis/Node.h
M  +22   -18   libs/ui/KisDocument.cpp
M  +11   -1    libs/ui/dialogs/kis_dlg_preferences.cc
M  +1    -0    libs/ui/dialogs/kis_dlg_preferences.h
M  +22   -9    libs/ui/forms/wdggeneralsettings.ui
M  +10   -0    libs/ui/kis_config.cc
M  +3    -0    libs/ui/kis_config.h
M  +4    -0    libs/ui/kis_layer_manager.cc
M  +2    -2    plugins/extensions/pykrita/sip/krita/Node.sip

https://invent.kde.org/kde/krita/commit/a1cd8d74b1a7e2b77010adae312b25168f6e9459

Comment 3 Emmet O'Neill 2020-05-15 23:34:16 UTC

Git commit 930bdbeedc5941e9796e14551b94aa3e363b2069 by Emmet O'Neill.
Committed on 15/05/2020 at 23:07.
Pushed by emmetoneill into branch 'emmetpdx/T12769/aninext'.

Added user setting for autopinning layers to timeline.

Currently this setting only applies to paint layers,
so other types of nodes will not be autopinned at all.
Related: bug 413805

M  +14   -14   libs/image/kis_base_node.cpp
M  +8    -1    libs/image/kis_base_node.h
M  +5    -5    libs/image/kis_layer_utils.cpp
M  +3    -3    libs/libkis/Node.h
M  +22   -18   libs/ui/KisDocument.cpp
M  +10   -3    libs/ui/dialogs/kis_dlg_preferences.cc
M  +1    -0    libs/ui/dialogs/kis_dlg_preferences.h
M  +22   -9    libs/ui/forms/wdggeneralsettings.ui
M  +10   -0    libs/ui/kis_config.cc
M  +3    -0    libs/ui/kis_config.h
M  +4    -0    libs/ui/kis_layer_manager.cc
M  +2    -2    plugins/extensions/pykrita/sip/krita/Node.sip

https://invent.kde.org/kde/krita/commit/930bdbeedc5941e9796e14551b94aa3e363b2069