Bug 414602

Summary: Label widths seem not to be considered for the color tab elements in the GUI layout generation
Product: [Frameworks and Libraries] libksane Reporter: Anton Arnold <aarnold.kde>
Component: generalAssignee: Kåre Särs <kare.sars>
Status: RESOLVED FIXED    
Severity: minor    
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Kubuntu   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Anton Arnold 2019-11-28 12:40:10 UTC
Label widths seem not to be considered for the color tab elements in the GUI layout generation.
Comment 1 Kåre Särs 2019-12-11 21:45:17 UTC
Git commit 992fd7c77d75c6267b615a3e9e982349639b9e51 by Kåre Särs, on behalf of Anton Arnold.
Committed on 11/12/2019 at 21:45.
Pushed by sars into branch 'master'.

Fix color-options layout & KSaneOptCombo::setValue()

Summary:
Related: bug 414601

This diff contains bugfixes that I fixed while developing the scan area+option ordering enhancements but are not related directly to them.

The items in the color layout where not updated correctly.
Remove the group separator before trying to write a value to a combo-box option.

Reviewers: sars, #kde_applications

Reviewed By: sars

Subscribers: aacid

Differential Revision: https://phabricator.kde.org/D25588

M  +3    -3    src/ksanewidget_p.cpp
M  +3    -2    src/options/ksaneoptcombo.cpp

https://commits.kde.org/libksane/992fd7c77d75c6267b615a3e9e982349639b9e51
Comment 2 Kåre Särs 2019-12-11 21:46:57 UTC
Git commit 3130174cae4e0410c7eef605a43a14550cd29e8a by Kåre Särs, on behalf of Anton Arnold.
Committed on 11/12/2019 at 21:46.
Pushed by sars into branch 'release/19.12'.

Fix color-options layout & KSaneOptCombo::setValue()

Summary:
Related: bug 414601

This diff contains bugfixes that I fixed while developing the scan area+option ordering enhancements but are not related directly to them.

The items in the color layout where not updated correctly.
Remove the group separator before trying to write a value to a combo-box option.

Reviewers: sars, #kde_applications

Reviewed By: sars

Subscribers: aacid

Differential Revision: https://phabricator.kde.org/D25588

M  +3    -3    src/ksanewidget_p.cpp
M  +3    -2    src/options/ksaneoptcombo.cpp

https://commits.kde.org/libksane/3130174cae4e0410c7eef605a43a14550cd29e8a