| Summary: | Icon does not respect the theme: black on black | ||
|---|---|---|---|
| Product: | [Plasma] plasma-browser-integration | Reporter: | postix <postix> |
| Component: | Firefox | Assignee: | Kai Uwe Broulik <kde> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | postix |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/plasma-browser-integration/269da15cf9b48a7bac5f121c7484d142767a992d | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
| Attachments: | Issue of the screenshot. | ||
While you can provide a theme icon in the app for dark theme, you cannot then override it programmatically. Git commit 269da15cf9b48a7bac5f121c7484d142767a992d by Kai Uwe Broulik. Committed on 13/04/2020 at 19:53. Pushed by broulik into branch 'master'. Provide light icon for dark mode via theme_icons I recall we originally didn't do it when Noah added these icons as browserAction.setIcon wasn't able to override the icon or something like this? However, it doesn't appear to be the case anymore in more recent versions. While the setIcons API doesn't support theme icons, only set the custom icon when the extension fails to start. So let's not jeopardize the normal user experience by this edge case. Differential Revision: https://phabricator.kde.org/D28806 M +18 -1 extension/manifest.json https://commits.kde.org/plasma-browser-integration/269da15cf9b48a7bac5f121c7484d142767a992d |
Created attachment 124130 [details] Issue of the screenshot. SUMMARY The icon of the plasma browser extension is dark, although Breeze dark is used for both Qt and GTK apps and the Firefox theme is set to dark too. Please see screenshot. SOFTWARE/OS VERSIONS Operating System: Manjaro Linux KDE Plasma Version: 5.17.3 KDE Frameworks Version: 5.65.0 Qt Version: 5.13.2 Firefox: 70.0.1 Extension: 1.6.1