Summary: | User Should definitely be warned every time an Invalid filename is used! | ||
---|---|---|---|
Product: | [Applications] dolphin | Reporter: | jc_josue3773 |
Component: | general | Assignee: | Dolphin Bug Assignee <dolphin-bugs-null> |
Status: | REPORTED --- | ||
Severity: | major | CC: | 15327614, gerrytrevis, kfm-devel, myusualnickname, witchhunterpro |
Priority: | NOR | ||
Version: | 19.08.2 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Microsoft Windows | ||
Latest Commit: | Version Fixed In: |
Description
jc_josue3773
2019-11-25 01:04:55 UTC
I have a path names with a colon and it brings up errors that the clips are invalid and the rendered files are invalid and it has taken days to figure out this problem. We should get an error message right away. I don't understand why the product has beeb changed to KDENLIVE It was DOLPHIN Oh god why? OK, clearly this bug is more general as it affects not just Dolphin but Kdenlive. So, what is needed is to fix it not just in Dolphin but on any other KDE software that is affected as well. Using Kubuntu 20.10 and this has been partially improved since Dolphin do throw an error - "Could not write to /path/" and Kate - "The document could not be saved, as it was not possible to write to /path/. Check that you have write access to this file or that enough disk space is available." The problem is those alerts can be misleading and my first thought is - Windows didn't properly unmount it's drives. So there should be some check on given filenames and pop-up offering to strip invalid characters. Furthermore, as stated in the link OP offered, there are some length restrictions to consider as well. TIL things are even worse. Dolphin clearly allows you to create a filename containing '/' (forward slash) on EXT4. 1) Don't know what is the reasoning behind this witchcraft but this is only doing more harm than good. 2) With all due respect to KDE devs, but don't they show the same upstream, to EXT4 founders. This is just unprofessional. 3) More ironically Dolphin throws nice warning when you try to name a directory containing the forward slash sign. This is plane inconsistency. Can "windows_names" mount option in NTFS3 kernel driver ease the implementation here? https://lore.kernel.org/lkml/3826a578-c371-bace-96a5-4e5dc83b5602@paragon-software.com/ It looks like a forward slash, but it is a replacement look alike character that we cannot type. I filed a bug for that in kde 4 but the bug was marked invalid because someone was proud of breaking our systems... adding a feature that they thought was cool. It is worse than that, Case preserving case insensitive filesystems can clobber data if a new filename is made differing only by case. It is worse than that, filenames can be anything other than null and forward slash. So the escape sequence that messes with terminals can be sent. Ever cat a binary file and have your terminal get messed up? Well, we're living with a huge vulnerability in files like that. Dolphin should flag files with harmful characters. Basically there should be a test to see if a file name is valid unicode, and then check for a list of banned characters. I would like this in the device driver/filesystem level on the system, but it requires communication with the user space. Creating a file with the same name but different case should cause a problem. This is a very severe problem that people just ignore. (In reply to witchhunter from comment #5) > TIL things are even worse. > Dolphin clearly allows you to create a filename containing '/' (forward > slash) on EXT4. > 1) Don't know what is the reasoning behind this witchcraft but this is only > doing more harm than good. > 2) With all due respect to KDE devs, but don't they show the same upstream, > to EXT4 founders. This is just unprofessional. > 3) More ironically Dolphin throws nice warning when you try to name a > directory containing the forward slash sign. This is plane inconsistency. |