Bug 414442

Summary:	Weather widget's station list needs double click to select a station
Product:	[Unmaintained] kdeplasma-addons	Reporter:	postix <postix>
Component:	Weather	Assignee:	Plasma Bugs List <plasma-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bugseforuns, fabian, foss, nate, postix
Priority:	NOR
Version First Reported In:	5.17.3
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://commits.kde.org/kdeplasma-addons/8861250b2e478d0c14e86704e4857de3ce03a784	Version Fixed/Implemented In:	5.18.0
Sentry Crash Report:

Description postix 2019-11-24 10:26:40 UTC

SUMMARY

Once some stations have been found, the user can select an item with a single left click but has to double click on a list item to actually choose it.


SOFTWARE/OS VERSIONS
Operating System: Manjaro Linux 
KDE Plasma Version: 5.17.3
KDE Frameworks Version: 5.65.0
Qt Version: 5.13.2

Comment 1 Nate Graham 2019-12-03 05:42:12 UTC

Git commit cf0f35aa070036a3cf79c8b58f43166963ffc240 by Nate Graham.
Committed on 03/12/2019 at 05:30.
Pushed by ngraham into branch 'Plasma/5.17'.

[applets/Weather] Activate Apply button when clicking on a table item
FIXED-IN: 5.17.4

M  +10   -4    applets/weather/package/contents/ui/config/WeatherStationPicker.qml

https://commits.kde.org/kdeplasma-addons/cf0f35aa070036a3cf79c8b58f43166963ffc240

Comment 2 Fabian Vogt 2020-01-13 13:46:48 UTC

Apparently the fix for this breaks the dialog more severely, as reported downstream (https://bugzilla.opensuse.org/show_bug.cgi?id=1160749):

> Running the latest Tumbleweed snapshot on Plasma 5.17.4, I have spotted a
> bug in the Plasma weather widget which makes selecting a location difficult
> / impossible.
> 
> Reproducible: Always
> 
> Steps to Reproduce:
> 1. Add the weather widget to the panel.
> 2. Right-click the widget and select 'configure weather report'
> 3. Click on the choose location button.
> 4. Type in 'Cambridge' as the city, select BBC as the provider, and hit
> 'search'.
> 5. The top item in the results is Cambridge MA, USA. Do not select this.
> Instead select any other entry (i.e. Cambridge, Cambridgeshire).
> 6. This will return you to the main widget config panel, and you will see
> that Cambridge MA USA has been selected as the location, not Cambridge,
> Cambridgeshire.
> 
> Actual Results:  
> The first location in the search results is always selected.
> 
> Expected Results:  
> The location I select should be the one which is set.

Comment 3 Nate Graham 2020-01-13 18:10:58 UTC

Oh dear.

Comment 4 Nate Graham 2020-01-13 21:12:58 UTC

Submitted https://phabricator.kde.org/D26640 to port the whole thing to QQC2+ListView. The old view was so buggy that it was easier to port it to the new new thing.

Comment 5 Patrick Silva 2020-01-21 15:38:56 UTC

*** Bug 414884 has been marked as a duplicate of this bug. ***

Comment 6 Nate Graham 2020-01-30 16:09:15 UTC

Git commit 8861250b2e478d0c14e86704e4857de3ce03a784 by Nate Graham.
Committed on 30/01/2020 at 16:08.
Pushed by ngraham into branch 'Plasma/5.18'.

[applets/weather] Port weather station picker to QQC2+ListView

Summary:
This fixes the bug I introduced when I fixed 414442 in the wrong way, makes the UI more
recular, removes a QQC1 dep, and makes the view fully keyboard-navigeable.
FIXED-IN: 5.18.0

Test Plan: {F7881687}

Reviewers: #vdg, #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: fvogt, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D26640

M  +53   -52   applets/weather/package/contents/ui/config/WeatherStationPicker.qml

https://commits.kde.org/kdeplasma-addons/8861250b2e478d0c14e86704e4857de3ce03a784