Bug 414398

Summary: PBI not noticing when a Firefox tab with a video was closed
Product: [Plasma] plasmashell Reporter: Nate Graham <nate>
Component: Media Player widgetAssignee: Kai Uwe Broulik <kde>
Status: RESOLVED WORKSFORME    
Severity: normal CC: plasma-bugs-null
Priority: NOR    
Version First Reported In: master   
Target Milestone: 1.0   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Nate Graham 2019-11-22 17:13:26 UTC 
OpenSUSE Tumbleweed, Latest Firefox, all KDE things from git master


STEPS TO REPRODUCE
1. Open Elisa and begin playing music
2. Open Firefox and navigate to any URL with an embedded video and begin to play the video (two recent examples: https://www.youtube.com/watch?v=bZSM5ZbdpWw and https://www.engadget.com/2019/11/21/macbook-pro-16-inch-review-ultimate-apple-laptop/)
3. Close the tab


OBSERVED RESULT
The Media Player widget still lists the Firefox tab as the currently playing source of media, even though you just closed it. This means that the media keys on my keyboard become useless and no longer control the music playing in Elisa until I manually go into the widget and change the source to Elisa or quit and restart Firefox.


EXPECTED RESULT
The media on that web page should be removed from the Media Player widget as soon as the tab is closed so that the widget automatically switches back to the previous media source and my keyboard media keys control Elisa again.
Comment 1 Kai Uwe Broulik 2019-11-22 17:16:03 UTC 
Is the media player actually shown as stopped? i.e. is it really p-b-i or just media controller failing to switch to the other player?
Comment 2 Kai Uwe Broulik 2019-11-22 17:18:04 UTC 
Fwiw, can't reproduce. Tab closed, firefox player completely disappears.
Comment 3 Nate Graham 2019-11-22 17:24:23 UTC 
The media in the media player widget does not show up as stopped hen I close the tab. It looks to the widget that it's still playing. If I re-open the closed tab and resume playback, the widget regains its connection with the media. Here's a Screen recording (it was slightly too large to attach): https://www.dropbox.com/s/z1q7y0tvxf0a33w/demo-2019-11-22_10.21.15.webm?dl=0
Comment 4 Kai Uwe Broulik 2019-11-22 17:27:01 UTC 
Ah you explicitly chose the media player... i think that's a media controller bug then. It uses a source that then goes away and then throws an exception updating the dialog or something. Re-assigning to media controller
Comment 5 Nate Graham 2019-11-22 17:29:18 UTC 
No sorry, I explicitly chose Firefox in the combobox for debugging purposes and forgot to undo that for the video. It's always on "Choose player automatically". But you may be right about this being a Media Player widget bug because it doesn't seem to be automatically switching at all either.
Comment 6 Nate Graham 2020-01-13 05:51:25 UTC 
This has consistently stopped happening. I wonder what was going on.