Bug 414366

Summary:	Bin effects only used on clip's first use
Product:	[Applications] kdenlive	Reporter:	steve-kde.org
Component:	Video Effects & Transitions	Assignee:	Vincent PINON <vpinon>
Status:	RESOLVED FIXED
Severity:	normal	CC:	jb, snd.noise
Priority:	NOR
Version First Reported In:	19.08.2
Target Milestone:	---
Platform:	RedHat Enterprise Linux
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description steve-kde.org 2019-11-21 15:21:50 UTC

SUMMARY
When applying an effect to a clip in the project bin, the effect is only used on the clip's first appearance in the timeline.

STEPS TO REPRODUCE
1. Add a clip to the project bin.
2. Drag the clip to the timeline.
3. Use the razor tool to cut the clip in the timeline.
4. Click the clip in the project bin.
5. Apply the Edge Crop effect and set some appropriate parameters on the effect.


OBSERVED RESULT
The Edge Crop effect works as expected up until the cut point.  After the cut point, the Edge Crop is no longer applied.

EXPECTED RESULT
The Edge Crop effect should apply to all uses of the clip.

SOFTWARE/OS VERSIONS
Linux: Fedora 31

Comment 1 farid 2019-11-25 14:40:58 UTC

cannot reproduce in latest master. please test and close.

Comment 2 farid 2019-11-25 14:45:16 UTC

JB, the only issue I noticed here is that the project monitor doesn't update when changing the values of a bin effect (in this case Edge Crop.)

Comment 3 Jean-Baptiste Mardelle 2019-11-26 17:34:28 UTC

Git commit 2586a759a8d9566743844ced3c711d949c8cca1e by Jean-Baptiste Mardelle.
Committed on 26/11/2019 at 17:29.
Pushed by mardelle into branch 'release/19.12'.

Refresh project monitor on bin effect change

M  +4    -0    src/core.cpp
M  +6    -0    src/monitor/monitor.cpp
M  +1    -0    src/monitor/monitor.h
M  +13   -0    src/monitor/monitormanager.cpp
M  +6    -0    src/monitor/monitormanager.h
M  +19   -0    src/timeline2/view/timelinecontroller.cpp
M  +2    -0    src/timeline2/view/timelinecontroller.h

https://invent.kde.org/kde/kdenlive/commit/2586a759a8d9566743844ced3c711d949c8cca1e