Bug 414346

Summary:	HTTP Proxy is broken in KTorrent with libkio 5.65
Product:	[Frameworks and Libraries] frameworks-kio	Reporter:	Alexander Trufanov <trufanovan>
Component:	HTTP	Assignee:	kdelibs bugs <kdelibs-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	git master
Target Milestone:	---
Platform:	Kubuntu
OS:	Linux
Latest Commit:	https://commits.kde.org/kio/c0ae03d14b0e58f2d3a23680b7b63c9fe46bdce6	Version Fixed In:	5.65
Sentry Crash Report:

Description Alexander Trufanov 2019-11-20 21:57:36 UTC

In KTorrent v5.1.2 the HTTP Proxy usage is broken on systems with libKF5KIOCore.so.5.65.0

KTorrent just doesn't connect to Privoxy on 128.0.0.1:8118 via socket.
It seems this happens since this commit: https://github.com/KDE/kio/commit/0911763b8f19c9fee3083e7f09382e1cde957723#diff-7d1e19d94808019256c1784b3dfc6801R2163
as QVariant with type QByteArray can't be converted to QStringList.

I'm submitting a patch to phabricator

SOFTWARE/OS VERSIONS
Operating System: Kubuntu 19.10
KDE Plasma Version: 5.17.3
KDE Frameworks Version: 5.64.0
Qt Version: 5.12.4
Kernel Version: 5.3.0-23-generic
OS Type: 64-bit

Comment 1 Alexander Trufanov 2019-11-21 11:37:47 UTC

Git commit c0ae03d14b0e58f2d3a23680b7b63c9fe46bdce6 by Alexander Trufanov.
Committed on 21/11/2019 at 11:25.
Pushed by trufanov into branch 'master'.

Fix HTTP proxy settings

Summary:
After SlaveBase::config() was replaced with SlaveBase::mapConfig()
the reading of "ProxyUrls" value had beed broken as QVariant with
type QByteArray can't be directly converted to QStringList.
It should be converted to QString and splitted.

Reviewers: #frameworks, meven

Reviewed By: meven

Subscribers: meven, kde-frameworks-devel

Tags: #frameworks
FIXED-IN: 5.65

Differential Revision: https://phabricator.kde.org/D25432

M  +1    -1    src/ioslaves/http/http.cpp

https://commits.kde.org/kio/c0ae03d14b0e58f2d3a23680b7b63c9fe46bdce6