Summary: | Dolphin crashes in KFileMetaData::UserMetaData::queryAttributes() when retrieving metadata from dangling symlink | ||
---|---|---|---|
Product: | [Frameworks and Libraries] frameworks-kfilemetadata | Reporter: | Ismael Asensio <isma.af> |
Component: | general | Assignee: | Pinak Ahuja <pinak.ahuja> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | a.stippich, bugseforuns, chesterhimes73, demm, duprezjm, eddymcv, govershay, kdedebug, kfm-devel, nate, sw4 |
Priority: | NOR | Keywords: | drkonqi |
Version: | 5.64.0 | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/kfilemetadata/4bb4195a6fc6841dd9ce1d3f564fc122b6032d86 | Version Fixed In: | 5.65 |
Description
Ismael Asensio
2019-11-17 11:44:31 UTC
Moving to KFileMetaData, since that's what's crashing. *** Bug 414372 has been marked as a duplicate of this bug. *** *** Bug 414453 has been marked as a duplicate of this bug. *** Git commit 4bb4195a6fc6841dd9ce1d3f564fc122b6032d86 by Ismael Asensio. Committed on 12/12/2019 at 20:50. Pushed by iasensio into branch 'master'. xattr: fix crash on dangling symlinks Summary: When requesting metadata on a dangling symlink, the framestack ends up calling `k_queryAttributes()` with the symlink path, where the `listxattr` syscall returns `size==-1` and `errno==ENOENT` (No such file or directory). This case was not covered before, and provoked a segfault on `QByteArray`. Full traceback on: https://bugs.kde.org/show_bug.cgi?id=414227 It might be also a good idea to always protect the function when `size==-1` Test Plan: - `bin/usermetadatawritertest` : added test - On dolphin, with panel information open, hover over a dangling symlink Reviewers: astippich, bruns Reviewed By: bruns Subscribers: bruns, kde-frameworks-devel, #baloo Tags: #frameworks, #baloo Differential Revision: https://phabricator.kde.org/D25414 M +11 -0 autotests/usermetadatawritertest.cpp M +1 -0 autotests/usermetadatawritertest.h M +6 -6 src/xattr_p.h https://commits.kde.org/kfilemetadata/4bb4195a6fc6841dd9ce1d3f564fc122b6032d86 *** Bug 415198 has been marked as a duplicate of this bug. *** *** Bug 415275 has been marked as a duplicate of this bug. *** *** Bug 415418 has been marked as a duplicate of this bug. *** *** Bug 415212 has been marked as a duplicate of this bug. *** I've just noticed that the fix was also commited to Frameworks 5.65, so it should be fixed from there on. *** Bug 415590 has been marked as a duplicate of this bug. *** *** Bug 415312 has been marked as a duplicate of this bug. *** |