Bug 414049

Summary:	Yakuake window can be maximised with keyboard shortcut, then stays maximised
Product:	[Applications] yakuake	Reporter:	Frank Steinmetzger <dev+kde>
Component:	general	Assignee:	Eike Hein <hein>
Status:	RESOLVED FIXED
Severity:	normal	CC:	asturm, manimax3, nate, nicolas.fella
Priority:	NOR
Version:	3.0.5
Target Milestone:	---
Platform:	Gentoo Packages
OS:	Linux
See Also:	https://bugs.kde.org/show_bug.cgi?id=424286
Latest Commit:	https://invent.kde.org/utilities/yakuake/commit/40326335554565cbc5a1ed9938828d60fa7cd214	Version Fixed In:	20.04.3
Sentry Crash Report:

Description Frank Steinmetzger 2019-11-12 00:37:21 UTC

Good day,

I assigned the shortcut Super+Y (German Layout, so on English Layout it’s Super+Z) to open Yakuake. I also set Super+X to maximise the active window.

Those two letters are right next to each other on the keyboard. Sometimes I hit the wrong key or press both Y and X accidentally. As a result, Yakuake opens up and maximises (normally, it is about 60 % wide and 30 % high). Now it is stuck at this screen-filling size. When I close and reopen it with Super+Y, it stays at that size. It also does not revert to its original size after pressing Super+X again (which usually un-maximises maximised windows).

In this situation, I have to open Yakuake’s settings and re-set the sliders for window width and height back from 100 %.

What is your opinion: I would like Yakuake to not react to the Maximise command and stay where it is designed to be. On a sidenote, I can also resize the Yakuake window with Alt+RMB, which causes layout issues in the window. But this time, a cycle of hiding and showing the window re-establishes the preset size.

Is there a way to completely disable resize events for the window, so that only Yakuake’s own settings may alter the window dimensions?

Thanks for your time.

Comment 1 Nicolas Fella 2020-06-24 12:14:38 UTC

https://invent.kde.org/utilities/yakuake/-/merge_requests/19 fixes the resetting to the original size.

I think the ability to quickly maximize and restore to the original size via shortcut is quite nice, once it works correctly.

Comment 2 Nicolas Fella 2020-06-24 15:32:33 UTC

Git commit 6415d22ec38bd96c9d9e5072f31a63d3cbe27634 by Nicolas Fella, on behalf of Anton Karmanov.
Committed on 24/06/2020 at 15:32.
Pushed by nicolasfella into branch 'master'.

Fix maximization behaviour

This commit fixes next issues:
- Yakuake main window geometry stays maximized (BUG: 414049).
- In some states maximized geometry may come to settings file and become
  persistent.
- Geometry becomes broken after size normalization.

M  +9    -11   app/mainwindow.cpp

https://invent.kde.org/utilities/yakuake/commit/6415d22ec38bd96c9d9e5072f31a63d3cbe27634

Comment 3 Nicolas Fella 2020-06-24 16:20:11 UTC

Git commit 40326335554565cbc5a1ed9938828d60fa7cd214 by Nicolas Fella, on behalf of Anton Karmanov.
Committed on 24/06/2020 at 15:34.
Pushed by nicolasfella into branch 'release/20.04'.

Fix maximization behaviour

This commit fixes next issues:
- Yakuake main window geometry stays maximized (BUG: 414049).
- In some states maximized geometry may come to settings file and become
  persistent.
- Geometry becomes broken after size normalization.

M  +9    -11   app/mainwindow.cpp

https://invent.kde.org/utilities/yakuake/commit/40326335554565cbc5a1ed9938828d60fa7cd214

Comment 4 Andreas Sturmlechner 2020-08-22 16:38:54 UTC

We got a downstream report for fullscreen mode broken in 20.04.3: https://bugs.gentoo.org/736858

Reverting 40326335554565cbc5a1ed9938828d60fa7cd214 fixes the regression.

Comment 5 Maximilian Schiller 2020-08-22 17:47:40 UTC

Yeah, this is (kinda) fixed in 20.08. I didn't add the fix to the 20.04 release because 20.04.03 was the last bugfix release.

See https://bugs.kde.org/show_bug.cgi?id=424286
and the fix https://invent.kde.org/utilities/yakuake/-/merge_requests/26