Summary: | Multiple dialogs open when creating a sticky note with a stylus | ||
---|---|---|---|
Product: | [Applications] okular | Reporter: | Rafael Brandmaier <rafael.brandmaier> |
Component: | general | Assignee: | Okular developers <okular-devel> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | haxtibal, nate, oliver.sander |
Priority: | NOR | ||
Version: | 1.8.2 | ||
Target Milestone: | --- | ||
Platform: | openSUSE | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/kde/okular/commit/00640370d3b138ef247b5a67a4fc019b968a3cf3 | Version Fixed In: |
Description
Rafael Brandmaier
2019-11-09 22:58:12 UTC
Actually this may in fact be Okular-related. We do have some control over stylus behavior; see https://cgit.kde.org/okular.git/commit/?id=f4d70641c3028e614aac9dece0c85f9b20aa1054. This one sounds familiar, duplicate of bug 409638? If yes we probably have a "good enough" fix of the symptom prepared at https://invent.kde.org/kde/okular/merge_requests/13. I can't reproduce the issue myself due to lack of pen hardware, but Oliver confirmed MR13 fixes at least bug 409638. The root cause is maybe buried somewhere in the Qt / X11 input stack, but it's hard to figure out unless the problem was reproducible in a debuggable environment. Yep, looks like the exact same issue, thanks! Is there anything blocking https://invent.kde.org/kde/okular/merge_requests/13? *** This bug has been marked as a duplicate of bug 409638 *** (In reply to Nate Graham from comment #3) > Is there anything blocking > https://invent.kde.org/kde/okular/merge_requests/13? It should be ready. We just haven't talked about the issue for some time and I'd like to wait for a final brief OK. Git commit 00640370d3b138ef247b5a67a4fc019b968a3cf3 by Tobias Deiminger. Committed on 01/12/2019 at 10:00. Pushed by tobiasdeiminger into branch 'release/19.12'. Fix spurious dialogs in PickPointEngine In the case of multiple input events, the local event loop of QInputDialog was processing pending events before m_creationCompleted could be cleared. This allowed recursive calls to PickPointEngine::end, even on wrong events (e.g. MouseMove shouldn't cause end(), but it did). Related: bug 409638 M +7 -0 ui/pageviewannotator.cpp https://invent.kde.org/kde/okular/commit/00640370d3b138ef247b5a67a4fc019b968a3cf3 |