Bug 413956

Summary:	Night color location values doesn’t use regional settings for decimal separator
Product:	[Applications] systemsettings	Reporter:	Karl Ove Hufthammer <karl>
Component:	kcm_nightcolor	Assignee:	Plasma Bugs List <plasma-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	andreas, bugseforuns, isma.af, kdebugs, kwin-bugs-null, nate, stargatesg
Priority:	NOR
Version First Reported In:	6.0.2
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/plasma/plasma-workspace/-/commit/cd5111de2c7323c28a5295fe713868bf25e9fcdd	Version Fixed/Implemented In:	6.0.3
Sentry Crash Report:

Description Karl Ove Hufthammer 2019-11-08 18:37:13 UTC

SUMMARY
The “Detect Location” feature in the night color settings returns and shows latitude and longitude values using a period instead of using the decimal separator specified in the regional settings (e.g., it shows 60.3984 instead of 60,3984 when using the Norwegian Nynorsk region settings).

STEPS TO REPRODUCE
1. Go to the regional settings and make sure you use a format where numbers are formatted using comma as the decimal separator.
2. Open the night color system settings.
3. Set the operation mode to “Location”.
4. Press “Detect Location”.

OBSERVED RESULT
The latitude and longitude fields are populated with numbers using period as the decimal separator (e.g., 60.3984).

EXPECTED RESULT
The latitude and longitude fields should be populated with numbers using the system settings for numbers, i.e., with comma as the decimal separator (e.g., 60,3984).

SOFTWARE/OS VERSIONS
Operating System: openSUSE Tumbleweed 20191104
KDE Plasma Version: 5.17.2
KDE Frameworks Version: 5.63.0
Qt Version: 5.13.1
Kernel Version: 5.3.8-1-default
OS Type: 64-bit
Processors: 4 × Intel® Core™ i5-2500 CPU @ 3.30GHz
Memory: 15,6 GiB

ADDITIONAL INFORMATION
Both numbers using . and , are accepted in when entering the latitude and longitude manually. (I don’t know if both work, as the sunset/sunrise times are not automatically updated when you change the latitude and/or longitude values.)

Comment 1 Marek 2023-01-03 15:03:46 UTC

Happens to me as well. I have regional settings with ',' as a decimal separator. Few other points:
- when I'm changing the values, it only allows me to enter them with respecting the regional settings (I can enter '47,3245', but not '47.3245')
- after changing the values I can't save them (the Apply button is greyed out)
- when I go to other tab, there is no dialog that the 'settings have changed'
- afer going back to the Night Color settings, the values I entered are clipped from the decimal separator to the end (so '47,3245' becomes '47')

I tested this with Czech regional settings for numbers.

SOFTWARE/OS VERSIONS
Operating System: EndeavourOS
KDE Plasma Version: 5.26.4
KDE Frameworks Version: 5.101.0
Qt Version: 5.15.7
Kernel Version: 6.1.2-arch1-1 (64-bit)
Graphics Platform: Wayland

Comment 2 Andreas Nyback 2023-05-12 00:53:13 UTC

Same problem here. When choosing sunset and sunrise on "present location" it will fill in the location with "," in the latitude and longitude numbers. (My localization preferences set to Swedish with comma as decimal separator)
The location will not work and i will get night mode even if its daytime.

Switching to manual sunset and sunrise location and choosing my spot on the map it will fill in the latitude and longitude numbers with periods and the location will work as expected and i will get a working night mode following sunset and sunrise.

Operating System: Devuan GNU/Linux 5
KDE Plasma Version: 5.27.2
KDE Frameworks Version: 5.103.0
Qt Version: 5.15.8
Kernel Version: 6.1.0-8-amd64 (64-bit)
Graphics Platform: X11
Processors: 4 × Intel® Core™ i7-5500U CPU @ 2.40GHz
Memory: 15.4 Gibyte of RAM
Graphics Processor: Mesa Intel® HD Graphics 5500
Manufacturer: GIGABYTE
Product Name: GB-BXi7-5500
System Version: 1.x

Comment 3 Ismael Asensio 2024-03-12 19:14:14 UTC

*** Bug 453825 has been marked as a duplicate of this bug. ***

Comment 4 Bug Janitor Service 2024-03-12 20:43:19 UTC

A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4058

Comment 5 Ismael Asensio 2024-03-13 22:32:09 UTC

Git commit 50493289c7e2b7bfa6f4849fa8bb9e464f7b4eba by Ismael Asensio.
Committed on 13/03/2024 at 22:18.
Pushed by iasensio into branch 'master'.

kcms/nightcolor: Make manual lat/lon respect locale decimal point

Use the locale-aware parsing functions for the decimal values

To be able to work with the TextField validator in a semi-sane
way without handicapping the user input, just update the backend
value when finishing the edition.

This let's us simplify the logic and also fix resetting to the
last good value on a wrong input, which was intended but also
wasn't working before.
FIXED-IN: 6.0.3

M  +10   -16   kcms/nightcolor/ui/NumberField.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/50493289c7e2b7bfa6f4849fa8bb9e464f7b4eba

Comment 6 Ismael Asensio 2024-03-13 22:50:44 UTC

Git commit cd5111de2c7323c28a5295fe713868bf25e9fcdd by Ismael Asensio.
Committed on 13/03/2024 at 22:33.
Pushed by iasensio into branch 'Plasma/6.0'.

kcms/nightcolor: Make manual lat/lon respect locale decimal point

Use the locale-aware parsing functions for the decimal values

To be able to work with the TextField validator in a semi-sane
way without handicapping the user input, just update the backend
value when finishing the edition.

This let's us simplify the logic and also fix resetting to the
last good value on a wrong input, which was intended but also
wasn't working before.
FIXED-IN: 6.0.3


(cherry picked from commit 50493289c7e2b7bfa6f4849fa8bb9e464f7b4eba)

M  +10   -16   kcms/nightcolor/ui/NumberField.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/cd5111de2c7323c28a5295fe713868bf25e9fcdd