Bug 413807

Summary: Timeline docker right click is hasty
Product: [Applications] krita Reporter: WOAS <korotkih.00>
Component: AnimationAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: ahab.greybeard, halla
Priority: NOR    
Version: 4.2.7.1   
Target Milestone: ---   
Platform: Microsoft Windows   
OS: Microsoft Windows   
Latest Commit: Version Fixed In:

Description WOAS 2019-11-04 15:01:51 UTC
0. Create a new project, open timeline docker
1. right click on the layer's label in timeline docker
2. Now depending on how fast you let go of the mouse, it occasionally creates a new layer by accident. You either have to hold right click for very long or let go extremely fast which is annoying (as it is not the case with any other right-click operation)
Comment 1 Halla Rempt 2019-11-04 15:03:48 UTC
That's not something we actually control, I'm afraid. We don't implement the way menus work ourselves, it's part of the toolkit.
Comment 2 Ahab Greybeard 2019-11-05 08:40:29 UTC
Reopening with an observation and a suggestion:

I don't think this is caused by 'timimg' but is caused by slight movement of the mouse/pen during the right-click.

When that context menus opens, the New Layer entry is at the top of the list box and a very small movement of the cursor will highlight it so that if you release the right-click while it is highlighted, the action is triggered, i.e. a new layer will be created.

A similar situation occurred in other context menus and that was fixed by putting a non-active label item at the top of the list of actions. These can be seen as e.g. 'Selection Actions' and 'Vector Shape Actions' when working on the main canvas.

Is it possible to do the same for the Timeline docker context menu?
Comment 3 Dmitry Kazakov 2020-04-07 12:43:48 UTC
Git commit 672981dbdb0d06efd78ee915d8d166a490337b5e by Dmitry Kazakov, on behalf of Emmet O'Neill.
Committed on 07/04/2020 at 12:43.
Pushed by dkazakov into branch 'master'.

Added simple headers to timeline context menus.

This was suggested as a way to mitigate accidental menu selections on
click release/negative edge.

M  +7    -1    plugins/dockers/animation/timeline_frames_view.cpp
M  +4    -0    plugins/dockers/animation/timeline_ruler_header.cpp

https://invent.kde.org/kde/krita/commit/672981dbdb0d06efd78ee915d8d166a490337b5e
Comment 4 Dmitry Kazakov 2020-04-08 18:34:00 UTC
Git commit 267618463b76c4b1c9e138a5c50a316e382591da by Dmitry Kazakov, on behalf of Emmet O'Neill.
Committed on 08/04/2020 at 18:33.
Pushed by dkazakov into branch 'krita/4.3'.

Added simple headers to timeline context menus.

This was suggested as a way to mitigate accidental menu selections on
click release/negative edge.

M  +7    -1    plugins/dockers/animation/timeline_frames_view.cpp
M  +4    -0    plugins/dockers/animation/timeline_ruler_header.cpp

https://invent.kde.org/kde/krita/commit/267618463b76c4b1c9e138a5c50a316e382591da