Bug 413726

Summary: 'Show Painting Assistants', 'Show Assistant Previews', 'Show Reference Images' state are not saved to KRA file
Product: [Applications] krita Reporter: acc4commissions
Component: GeneralAssignee: Krita Bugs <krita-bugs-null>
Status: CONFIRMED ---    
Severity: wishlist CC: halla, scottpetrovic, vladimir.firefly.savic
Priority: NOR    
Version First Reported In: nightly build (please specify the git hash!)   
Target Milestone: ---   
Platform: Microsoft Windows   
OS: Microsoft Windows   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description acc4commissions 2019-11-02 03:20:19 UTC
SUMMARY
'Show Painting Assistants', 'Show Assistant Previews', 'Show Reference Images' are not disabled after re-opening krita or document again.

git 2c21a4c


STEPS TO REPRODUCE
1. Disable any of those 3 options in menu > view.
2. Close the document in krita. 
3. Open any document again.

OBSERVED RESULT
The options are checked again.

EXPECTED RESULT
Options should be disabled.

SOFTWARE/OS VERSIONS
Windows: Win7
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION

I'm not sure if any of other options behaves the same way or it's just those 3.
Comment 1 Scott Petrovic 2019-11-04 15:35:28 UTC
This would be a feature request that needs discussion.

What you are proposing is that these features be off by default. 

We could do that, but we will probably be getting new bug reports from people asking why their assistants aren't shown...which of course is the result of having them turned off by default.
Comment 2 acc4commissions 2019-11-04 18:06:13 UTC
(In reply to Scott Petrovic from comment #1)
> This would be a feature request that needs discussion.
> 
> What you are proposing is that these features be off by default. 

No. It's a bug. I turn the options off > close krita or the document > open krita or any document again > and the options are automatically turned on, which is not an expected behavior. Once it turned off(or on), it should stay that way.
Comment 3 acc4commissions 2019-11-04 18:07:02 UTC
Wait, is it intentional?
Comment 4 Scott Petrovic 2019-11-04 19:17:15 UTC
This checkbox is tracked by document...not at the application level. This was requested a while ago because that is what some people wanted. To have different on/off settings per document. When you open a document and turn one of those settings off, that setting should only be kept for that specific document. 

Because of this "per document" way of storage, there is no way for Krita to know that you want that setting saved globally...and not just for a specific document.

it is a bit confusing -- but hopefully it makes a bit more sense.
Comment 5 acc4commissions 2019-11-04 19:25:10 UTC
(In reply to Scott Petrovic from comment #4)
> This checkbox is tracked by document...not at the application level. This
> was requested a while ago because that is what some people wanted. To have
> different on/off settings per document. When you open a document and turn
> one of those settings off, that setting should only be kept for that
> specific document. 
> 
> Because of this "per document" way of storage, there is no way for Krita to
> know that you want that setting saved globally...and not just for a specific
> document.
> 
> it is a bit confusing -- but hopefully it makes a bit more sense.

In here, it's not even 'per document'. I close and open the same document, and the options are always checked from the second time.
Comment 6 Scott Petrovic 2019-11-04 23:16:13 UTC
It must not be saving that setting per document then. That is where that checkbox data is stored when you click it.

Maybe what you are trying to ask for is that those settings are saved to the KRA file?
Comment 7 acc4commissions 2019-11-05 05:53:22 UTC
No, I'm saying, that apparently krita *DOESN'T STORE* the 'checkbox data' at all. Not in the kra file, not in the krita itself, nowhere. 

And it seems to be a bug, so I'm asking for you to make it saved/stored somewhere. I don't care if it's the kra file or somewhere else.
Comment 8 Scott Petrovic 2019-11-05 13:18:36 UTC
Alright. I am going to confirm this then and change the title of this report so it is a bit more clear for a developer to know what to do. 

Thanks for the report.
Comment 9 Vladimir Savic 2021-12-17 22:20:29 UTC
This is slowly starting to bother me too. I work on several illustrations at the same time and having to fiddle with three checkboxes each time I save->open starts feeling like a big waste of time. Having to do it multiple times a day for numerous documents makes it disadvantageous. The subjective feeling is probably worse than it really is, but nevertheless, it is irritating.

Low priority, I know, but still...
Comment 10 Halla Rempt 2021-12-18 09:52:48 UTC
Currently, this state is per view -- you can have multiple views on a document, and have them on in one view and off in another view.
Comment 11 Vladimir Savic 2021-12-18 10:01:02 UTC
(In reply to Halla Rempt from comment #10)
> Currently, this state is per view -- you can have multiple views on a
> document, and have them on in one view and off in another view.

Nice point. I totally forgot about the fact that multiple views are possible.

But still nothing gets saved with KRA file. That's the main problem. It would be nice to have at least checkbox' states of the last closed view saved with the file.
Comment 12 Halla Rempt 2021-12-18 10:16:36 UTC
Yes, I agree.  I just wanted to note this down so I won't spend another ten minutes looking into this before coming to this realization :-)