| Summary: | Dolphin File-Manager Doesn't Create Thumbnails when Using the 'gtk2' Style of 'qtstyleplugins' | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | Jamie Michelle <ladyjamie> |
| Component: | general | Assignee: | Dolphin Bug Assignee <dolphin-bugs-null> |
| Status: | RESOLVED WORKSFORME | ||
| Severity: | normal | CC: | fabian, kfm-devel |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Jamie Michelle
2019-10-30 20:45:04 UTC
Please try it with a style which works fine and post the output of "hexdump -C /proc/$(pgrep -n thumbnail.so)/cmdline". I cannot reproduce the issue here with glib2 2.62.1 here on Tumbleweed, cmdline is always terminated with a nullbyte. (In reply to Fabian Vogt from comment #1) > Please try it with a style which works fine and post the output of "hexdump > -C /proc/$(pgrep -n thumbnail.so)/cmdline". > > I cannot reproduce the issue here with glib2 2.62.1 here on Tumbleweed, > cmdline is always terminated with a nullbyte. Hi, Fabian Vogt. My apologies for not responding sooner. Here is the output of your command: $ hexdump -C /proc/$(pgrep -n thumbnail.so)/cmdline 00000000 42 4f 4f 54 5f 49 4d 41 47 45 3d 2f 62 6f 6f 74 |BOOT_IMAGE=/boot| 00000010 2f 76 6d 6c 69 6e 75 7a 2d 34 2e 31 34 2d 78 38 |/vmlinuz-4.14-x8| 00000020 36 5f 36 34 20 72 6f 6f 74 3d 55 55 49 44 3d 32 |6_64 root=UUID=2| 00000030 61 63 38 31 65 36 34 2d 66 30 61 39 2d 34 66 64 |ac81e64-f0a9-4fd| 00000040 64 2d 61 38 65 63 2d 63 66 34 36 37 36 33 33 31 |d-a8ec-cf4676331| 00000050 66 62 61 20 72 77 20 71 75 69 65 74 20 63 72 79 |fba rw quiet cry| 00000060 70 74 64 65 76 69 63 65 3d 55 55 49 44 3d 39 62 |ptdevice=UUID=9b| 00000070 38 66 35 33 33 30 2d 62 39 61 31 2d 34 34 62 37 |8f5330-b9a1-44b7| 00000080 2d 62 63 64 31 2d 36 35 37 36 38 37 30 30 34 39 |-bcd1-6576870049| 00000090 32 66 3a 6c 75 6b 73 2d 39 62 38 66 35 33 33 30 |2f:luks-9b8f5330| 000000a0 2d 62 39 61 31 2d 34 34 62 37 2d 62 63 64 31 2d |-b9a1-44b7-bcd1-| 000000b0 36 35 37 36 38 37 30 30 34 39 32 66 20 72 6f 6f |65768700492f roo| 000000c0 74 3d 2f 64 65 76 2f 6d 61 70 70 65 72 2f 6c 75 |t=/dev/mapper/lu| 000000d0 6b 73 2d 39 62 38 66 35 33 33 30 2d 62 39 61 31 |ks-9b8f5330-b9a1| 000000e0 2d 34 34 62 37 2d 62 63 64 31 2d 36 35 37 36 38 |-44b7-bcd1-65768| 000000f0 37 30 30 34 39 32 66 20 72 65 73 75 6d 65 3d 2f |700492f resume=/| 00000100 64 65 76 2f 6d 61 70 70 65 72 2f 6c 75 6b 73 2d |dev/mapper/luks-| 00000110 39 62 38 66 35 33 33 30 2d 62 39 61 31 2d 34 34 |9b8f5330-b9a1-44| 00000120 62 37 2d 62 63 64 31 2d 36 35 37 36 38 37 30 30 |b7-bcd1-65768700| 00000130 34 39 32 66 0a |492f.| 00000135 Also, the following threads are relevant to this problem: * Jamie Michelle, "Recent Versions of GLib Break Dolphin File-Manager's Thumbnailing when Using 'gtk2' Style", Oct. 29, 2019, https://gitlab.gnome.org/GNOME/glib/issues/1923 . Simon McVittie, "goption: Relax assertion to avoid being broken by kdeinit5", Oct. 31, 2019, https://gitlab.gnome.org/GNOME/glib/commit/15a5c2dcf8edacbf7e105c97bd1f34295b1f2a98 . (In reply to Jamie Michelle from comment #2) > (In reply to Fabian Vogt from comment #1) > > Please try it with a style which works fine and post the output of "hexdump > > -C /proc/$(pgrep -n thumbnail.so)/cmdline". > > > > I cannot reproduce the issue here with glib2 2.62.1 here on Tumbleweed, > > cmdline is always terminated with a nullbyte. > > Hi, Fabian Vogt. My apologies for not responding sooner. Here is the output > of your command: > > $ hexdump -C /proc/$(pgrep -n thumbnail.so)/cmdline > 00000000 42 4f 4f 54 5f 49 4d 41 47 45 3d 2f 62 6f 6f 74 > |BOOT_IMAGE=/boot| Unfortunately thumbnail.so was not running at that point so you dumped /proc/cmdline instead... Can you try again? You should get different output. > Also, the following threads are relevant to this problem: > > * Jamie Michelle, "Recent Versions of GLib Break Dolphin File-Manager's > Thumbnailing when Using 'gtk2' Style", Oct. 29, 2019, > https://gitlab.gnome.org/GNOME/glib/issues/1923 . Apparently a GLib dev had a look at our code as well: > More specifically, it looks like kdeinit5 overwrites the memory occupied by the elements of argv, which in turn changes /proc/self/cmdline (although I can't see how it would end up non-terminated). So he can't spot the bug either... > Simon McVittie, "goption: Relax assertion to avoid being broken by > kdeinit5", Oct. 31, 2019, > https://gitlab.gnome.org/GNOME/glib/commit/ > 15a5c2dcf8edacbf7e105c97bd1f34295b1f2a98 . Ok, so it's fixed upstream in glib, that's good news. Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging If you have already provided the requested information, please mark the bug as REPORTED so that the KDE team knows that the bug is ready to be confirmed. Thank you for helping us make KDE software even better for everyone! This bug has been in NEEDSINFO status with no change for at least 30 days. The bug is now closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging Thank you for helping us make KDE software even better for everyone! |