| Summary: | Keyboard shortcuts don't work in fullscreen mode (patch included) | ||
|---|---|---|---|
| Product: | [Applications] kdenlive | Reporter: | Martin K <tiyim11227> |
| Component: | User Interface & Miscellaneous | Assignee: | Jean-Baptiste Mardelle <jb> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | snd.noise |
| Priority: | NOR | ||
| Version First Reported In: | git-master | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/kde/kdenlive/commit/b93ac8128448c8a8f38bb4159bd2b831f7ef9cb1 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
Git commit b93ac8128448c8a8f38bb4159bd2b831f7ef9cb1 by Jean-Baptiste Mardelle. Committed on 31/10/2019 at 12:14. Pushed by mardelle into branch 'master'. Fix keyboard handling in monitor fullscreen mode, thanks to Martin K. M +3 -11 src/monitor/monitor.cpp M +0 -1 src/monitor/monitor.h https://invent.kde.org/kde/kdenlive/commit/b93ac8128448c8a8f38bb4159bd2b831f7ef9cb1 Thanks Martin K for your contribution! :) |
SUMMARY Keyboard shortcuts don't work when the clip/project monitor is in fullscreen. In other words, one cannot toggle between fullscreen and normal mode using only keyboard shortcuts. Clicking on the monitor while it is in fullscreen mode makes it responsive to keyboard input again, which indicates some kind of focus problem. STEPS TO REPRODUCE 1. Bind the keyboard shortcut "F" to Switch Monitor FullScreen 2. Hit "F" to enter fullscreen mode (works) 3. Hit "F" to exit fullscreen mode (does NOT work) OBSERVED RESULT The monitor stays in fullscreen mode. EXPECTED RESULT The monitor returns to normal mode. Qt Version: 5.11.3 KDE Frameworks Version: 5.54.0 kf5-config: 1.0 ADDITIONAL INFORMATION The following patch seems to fix the problem (I am not sure if it's the right solution): index e931f0f5d..24f92b147 100644 --- a/src/monitor/monitor.cpp +++ b/src/monitor/monitor.cpp @@ -171,7 +171,7 @@ Monitor::Monitor(Kdenlive::MonitorId id, MonitorManager *manager, QWidget *paren connect(m_qmlManager, &QmlManager::effectPointsChanged, this, &Monitor::effectPointsChanged); auto *monitorEventEater = new QuickMonitorEventEater(this); - m_glWidget->installEventFilter(monitorEventEater); + m_videoWidget->installEventFilter(monitorEventEater); connect(monitorEventEater, &QuickMonitorEventEater::doKeyPressEvent, this, &Monitor::doKeyPressEvent); glayout->addWidget(m_videoWidget, 0, 0);