Summary: | Sometimes left and right margins of full-size preview image sheets are too large and image is too small | ||
---|---|---|---|
Product: | [Applications] Discover | Reporter: | Gerhard Dittes <g-a-d> |
Component: | discover | Assignee: | Dan Leinir Turthra Jensen <leinir> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | aleixpol, matthias, nate |
Priority: | NOR | Flags: | g-a-d:
Usability+
|
Version: | 5.17.2 | ||
Target Milestone: | --- | ||
Platform: | Neon | ||
OS: | Linux | ||
See Also: | https://bugs.kde.org/show_bug.cgi?id=413812 | ||
Latest Commit: | https://cgit.kde.org/discover.git/commit/?id=22e39b6f14d63a10bae1bb0aa105b6455849781f | Version Fixed In: | 5.18.0 |
Attachments: |
Good looking thumbnail, but tiny and unsharp image when clicked/"opened" finally
Insane margins (especially the left and right one) Insane (tiny) size compared to thumbnail Pretty unsharp Better make the thumbnail not clickable... ;-) BitWarden app on Flathub Discover produces empty space for "non-existent/transparent" images |
Description
Gerhard Dittes
2019-10-30 13:43:13 UTC
Created attachment 123590 [details]
Good looking thumbnail, but tiny and unsharp image when clicked/"opened" finally
Created attachment 123591 [details]
Insane margins (especially the left and right one)
Created attachment 123592 [details]
Insane (tiny) size compared to thumbnail
Created attachment 123593 [details]
Pretty unsharp
Created attachment 123594 [details]
Better make the thumbnail not clickable... ;-)
FWIW, the mentioned issues are valid for (most likely all) previous versions of Plasma, too. Regards, Gerhard (aka Gerardo) I can reproduce the occasional issues with inappropriately large margins on the left and right side. However the other issues you describe where the full-size image is worse than the preview are the fault of the distro packaging, which defines these images. I'm using openSUSE Tumbleweed and I don't see any of these issues. The thumbnails are small, and the full-sized images are nice and big and sharp. Let's keep this bug report for fixing the margins. Please report the issue about the small and fuzzy full-sized images to Neon (the neon product on https://bugs.kde.org). Thanks! @Nate: Thanks for your information. The distro-thing is really a pity, as I actually use Debian stable/testing (where I experience the same issues, too). I guess, that all Debian derivatives suffer from the same circumstance... Yeah that would make sense if you see this problem in Debian too. Neon is inhering Ubuntu's stuff, which is inheriting Debian. Best fix it there, then. You may want to work with Matthias Klumpp (CCd) who is the Debian Discover packager and author and maintainer of Appstream, the spec that defines how these screenshots are presented. Created attachment 123598 [details] BitWarden app on Flathub An easily reproducible case is the BitWarden app available on Flathub. Its screenshot exhibits excessive side margins and is also quite a bit smaller than the actual image file [1] specified in the AppStream metadata [2]. In fact all the thumbnails that are too small or blurry seem to have these excessive side margins... [1] https://camo.githubusercontent.com/efc3b807d82fd8eaf35375f5f2600414c17813c6/687474703a2f2f696d6775722e636f6d2f6f504d343479302e706e67 [2] https://github.com/flathub/com.bitwarden.desktop/blob/master/com.bitwarden.desktop.appdata.xml ScreenshotsModel.cpp seems to be downloading a small version of https://camo.githubusercontent.com/efc3b807d82fd8eaf35375f5f2600414c17813c6/687474703a2f2f696d6775722e636f6d2f6f504d343479302e706e67. Odd. Hi, as suggested, I've meanwhile filed a corresponding bug in Debian (to potentially tackle one of the mentioned problems there): https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=944117 Created attachment 123717 [details]
Discover produces empty space for "non-existent/transparent" images
@Nate: Inspired by you, I did some tests on Tumbleweed, too. There (as well as on other distributions) I've found another related issue: Sometimes Discover reserves space for thumbnails even though no image is shown finally. Looks pretty untidy. Please see newly attached screenshot (showing entry for virtualbox). (Could we tackle this problem here, too?) Thx! The AppStream info for Virtualbox in Tumbleweed does in fact define a screenshot (https://www.virtualbox.org/attachment/wiki/Screenshots/OpenSuse13.2_on_Windows_7.png). Running discover from the CLI reveals the following error: qrc:/qml/ApplicationScreenshots.qml:149:17: QML Image: Error decoding: https://www.virtualbox.org/attachment/wiki/Screenshots/OpenSuse13.2_on_Windows_7.png: Unsupported image format The URL, despite its filename extension, leads to a web page and not to the actual image itself. The actual URL for the image is https://www.virtualbox.org/raw-attachment/wiki/Screenshots/OpenSuse13.2_on_Windows_7.png This is an openSUSE issue. However Discover should probably not display any screenshots section at all for images that have invalid URLs. Let's track that with Bug 413812. Git commit 05085877bc3d70b13ebc2d4bfa104da54e48a655 by Aleix Pol. Committed on 02/12/2019 at 18:07. Pushed by apol into branch 'Plasma/5.17'. Account for weirdly horizontal screenshots M +4 -2 discover/qml/ApplicationScreenshots.qml https://commits.kde.org/discover/05085877bc3d70b13ebc2d4bfa104da54e48a655 Git commit 4d8d007f6eef847267d917c0f6d889b51a1aebaf by Aleix Pol. Committed on 02/12/2019 at 18:17. Pushed by apol into branch 'Plasma/5.17'. Account for padding in the height of the screenshot popup M +1 -1 discover/qml/ApplicationScreenshots.qml https://commits.kde.org/discover/4d8d007f6eef847267d917c0f6d889b51a1aebaf Final issue fixed by https://cgit.kde.org/discover.git/commit/?id=22e39b6f14d63a10bae1bb0aa105b6455849781f (turned out to be a Discover issue after all). Speed of browsing screenshots is also improved. |