| Summary: | Text cut off at left and right edges of <50px wide vertical panel | ||
|---|---|---|---|
| Product: | [Unmaintained] kdeplasma-addons | Reporter: | Alexander Ewering <ae> |
| Component: | Weather | Assignee: | Plasma Bugs List <plasma-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | nate |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/kdeplasma-addons/8aba24da397cc9ae37d9d74f46661cbbd6b3c082 | Version Fixed/Implemented In: | 5.17.3 |
| Sentry Crash Report: | |||
| Attachments: | Screenshot | ||
What version of Plasma are you using? (In reply to Nate Graham from comment #1) > What version of Plasma are you using? Operating System: KDE neon 5.17 KDE Plasma Version: 5.17.1 KDE Frameworks Version: 5.63.0 Qt Version: 5.13.1 Kernel Version: 5.0.0-32-generic OS Type: 64-bit Processors: 8 × Intel® Core™ i7-4790T CPU @ 2.70GHz Memory: 7.7 GiB of RAM Sorry for the slightly harsh tone btw. I'm just a UI/UX fanatic and have grown to love KDE again after SuSE Linux 6.1 in 1997... so I want it to be perfect :) You sound like me! I can reproduce the issue for vertical panels of less than about 50px in width. Hehe, yes, I know it's not the best thing to complain about free stuff, but I'm just so amazed at KDE and especially Neon, it's really a huge relief after years of Windows 7. But we're totally off-topic ;) In any case, visually KDE is now light-years ahead, the one remaining layout problem IMO in most of Plasma and apps is inconsistent / missing / too small padding. I know many will now say that "it's all about information density", but then it'd be better to make fonts and icons a bit smaller and add a bit of padding instead. It's very important for quick visual categorization of elements by the user. Rant over now! :) Yikes, this code is thorny. Here's a patch that fixes it: https://phabricator.kde.org/D25082 Git commit 8aba24da397cc9ae37d9d74f46661cbbd6b3c082 by Nate Graham.
Committed on 08/11/2019 at 13:53.
Pushed by ngraham into branch 'Plasma/5.17'.
[applets/weather] Reduce label minimum width to accommodate narrow vertical panels
Summary:
The temperature label's minimum width was set high enough to overflow in a narrow
vertical panel. This patch reduces it, without regressing the layout elsewhere.
FIXED-IN: 5.17.3
Test Plan: {F7695929}
Reviewers: #vdg, #plasma, kossebau
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D25082
M +2 -2 applets/weather/package/contents/ui/IconAndTextItem.qml
https://commits.kde.org/kdeplasma-addons/8aba24da397cc9ae37d9d74f46661cbbd6b3c082
|
Created attachment 123566 [details] Screenshot The weather widget has layout issues: - Sometimes, especially with temperatures like "10.0 C", the text size is appearently calculated incorrectly, and the text is cut off on a vertical panel (see screenshot) - There is no padding whatsoever to the left and right, making the snug text appear ugly (same issue exists with the digital clock)