Summary: | Wallpaper slideshow set to "random" is not random at all | ||
---|---|---|---|
Product: | [Plasma] plasmashell | Reporter: | Mathias Homann <Mathias.Homann> |
Component: | Image Wallpaper | Assignee: | Marco Martin <notmart> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | halftough29a, kde, maxzhurkin, nate, plasma-bugs |
Priority: | NOR | ||
Version: | 5.17.1 | ||
Target Milestone: | 1.0 | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/plasma-workspace/9dca7d6cd44cbb16c6d7fb1aca5588760544b1d6 | Version Fixed In: | 5.18.0 |
Description
Mathias Homann
2019-10-26 06:53:22 UTC
i can actually choose "next wallpaper" from the desktop context menu, and I'll always get the same sequence of wallpapers.... so ... NOT random. You're right, fix(es) on review. is this by any chance related to the "plasma crashes during wallpaper change" fixes? Patches are https://phabricator.kde.org/D24985 and https://phabricator.kde.org/D24986. Git commit 868a6a9f62546be0c409615501bf54fb6fa8c910 by Nate Graham, on behalf of David Edmundson. Committed on 29/10/2019 at 19:38. Pushed by ngraham into branch 'Plasma/5.17'. [wallpapers/image] Seed random number generator Summary: Otherwise when we randomise the wallpaper order we will always get the same results. Test Plan: qDebug + ran twice Reviewers: #plasma, ngraham, davidre Reviewed By: ngraham, davidre Subscribers: davidre, apol, anthonyfieroni, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D24985 M +1 -0 wallpapers/image/slidefiltermodel.cpp https://commits.kde.org/plasma-workspace/868a6a9f62546be0c409615501bf54fb6fa8c910 Git commit 9dca7d6cd44cbb16c6d7fb1aca5588760544b1d6 by Nate Graham, on behalf of David Edmundson. Committed on 29/10/2019 at 19:39. Pushed by ngraham into branch 'Plasma/5.17'. [wallpapers/image] Randomise new batches of images in the slideshow Summary: There was a concious decision that when we add a new wallpaper we should append to the existing random order collection, rather than shuffle existing ones. The logic is fine but if we start with 0 wallpapers and then add 20 new ones we don't shuffle anything. This patch changes it so when a new batch of N wallpapers is added, those N are shuffled when appending to the existing sort order. FIXED-IN: 5.17.2 Test Plan: qDebug + ran a few times Reviewers: #plasma, ngraham, davidre Reviewed By: ngraham, davidre Subscribers: davidre, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D24986 M +1 -0 wallpapers/image/slidefiltermodel.cpp https://commits.kde.org/plasma-workspace/9dca7d6cd44cbb16c6d7fb1aca5588760544b1d6 (In reply to Nate Graham from comment #6) > Git commit 9dca7d6cd44cbb16c6d7fb1aca5588760544b1d6 by Nate Graham, on > behalf of David Edmundson. > Committed on 29/10/2019 at 19:39. > Pushed by ngraham into branch 'Plasma/5.17'. > > [wallpapers/image] Randomise new batches of images in the slideshow > > Summary: > There was a concious decision that when we add a new wallpaper we should > append to the existing random order collection, rather than shuffle > existing ones. > > The logic is fine but if we start with 0 wallpapers and then add 20 new > ones we don't shuffle anything. > > This patch changes it so when a new batch of N wallpapers is added, > those N are shuffled when appending to the existing sort order. > FIXED-IN: 5.17.2 > > Test Plan: qDebug + ran a few times > > Reviewers: #plasma, ngraham, davidre > > Reviewed By: ngraham, davidre > > Subscribers: davidre, plasma-devel > > Tags: #plasma > > Differential Revision: https://phabricator.kde.org/D24986 > > M +1 -0 wallpapers/image/slidefiltermodel.cpp > > https://commits.kde.org/plasma-workspace/ > 9dca7d6cd44cbb16c6d7fb1aca5588760544b1d6 Has this been released yet? Because now on 5.17.4 after changing my wallpaper directories I can definitively see patterns. Namely wallpapers from new directory I added are all showed one after another, but old ones also continue to appear in same order as they are structured in a directory. What's more after booting up the first wallpaper is actually random, but after that the next one will be second from the list, third one and so on. Version 5.17.5 string srand(time(nullptr)); exists same problem: same order of pictures after login as after logins before Can you check with Plasma 5.18? 5.17 is no longer supported, while 5.18 is an LTS release. On 5.18.3 works fine Great, thanks. |