Bug 413227

Summary:	'Desktop Toolbox' displayed in English on all display languages
Product:	[Plasma] plasmashell	Reporter:	Øystein Steffensen-Alværvik <epost.kde>
Component:	Edit Mode	Assignee:	Plasma Bugs List <plasma-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	kde, kde
Priority:	NOR
Version First Reported In:	5.17.0
Target Milestone:	1.0
Platform:	openSUSE
OS:	Linux
Latest Commit:	https://commits.kde.org/plasma-desktop/c79902431d9abd4ebb7c34c8350a18955367fe2f	Version Fixed In:	5.17.1
Sentry Crash Report:
Attachments:	'Desktop Toolbox' on the desktop Video of the untranslated title

Description Øystein Steffensen-Alværvik 2019-10-20 09:13:13 UTC

SUMMARY
The Desktop Toolbox's title is displayed in English, even though the display language is set to a non-English locale in the Language systemsettings module. Tested with Norwegian Nynorsk and German. The text has been translated and pushed to SVN.

Operating System: openSUSE Tumbleweed 20191016
KDE Plasma Version: 5.17.0
KDE Frameworks Version: 5.63.0
Qt Version: 5.13.1
Kernel Version: 5.3.5-1-default
OS Type: 64-bit
Processors: 4 × Intel® Core™ i5-4210U CPU @ 1.70GHz
Memory: 11,6 GiB

Comment 1 David Edmundson 2019-10-20 14:22:27 UTC

Can you show a screenshot of which title you mean please.

Comment 2 Øystein Steffensen-Alværvik 2019-10-20 15:06:02 UTC

Created attachment 123364 [details]
'Desktop Toolbox' on the desktop

Comment 3 Øystein Steffensen-Alværvik 2019-10-22 09:25:53 UTC

Created attachment 123400 [details]
Video of the untranslated title

In case my post wasn't clear: This occurs when moving the Toolbox's (or 'hamburger menu'?) default position from the sides into the desktop.

Comment 4 Kai Uwe Broulik 2019-10-22 09:33:36 UTC

It's missing a domain

Comment 5 Øystein Steffensen-Alværvik 2019-10-22 09:34:57 UTC

(In reply to Kai Uwe Broulik from comment #4)
> It's missing a domain

You mean the video isn't working? Shows up for me.

Comment 6 Kai Uwe Broulik 2019-10-22 09:36:49 UTC

The i18n translation call is missing a translation domain, I mean :) 
Patch: https://phabricator.kde.org/D24854

Comment 7 Kai Uwe Broulik 2019-10-22 09:38:30 UTC

Git commit c79902431d9abd4ebb7c34c8350a18955367fe2f by Kai Uwe Broulik.
Committed on 22/10/2019 at 09:37.
Pushed by broulik into branch 'Plasma/5.17'.

[Desktop Toolbox] Add missing i18n domain
FIXED-IN: 5.17.1

Differential Revision: https://phabricator.kde.org/D24854

M  +3    -1    toolboxes/desktoptoolbox/contents/ui/ToolBoxButton.qml

https://commits.kde.org/plasma-desktop/c79902431d9abd4ebb7c34c8350a18955367fe2f

Comment 8 Øystein Steffensen-Alværvik 2019-10-22 10:16:09 UTC

Nice, thanks for the quick patch!