Bug 413145

Summary:	No Context Help button in Aurorae themes
Product:	[Plasma] kwin	Reporter:	Alison Watson <marrub>
Component:	aurorae	Assignee:	KWin default assignee <kwin-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bugseforuns
Priority:	NOR	Flags:	vlad.zahorodnii: ReviewRequest+
Version First Reported In:	5.16.5
Target Milestone:	---
Platform:	Arch Linux
OS:	Linux
URL:	https://phabricator.kde.org/D24851
Latest Commit:	https://commits.kde.org/kwin/982fefd38974667d818b0b91698db7defe62483a	Version Fixed/Implemented In:	5.17.1
Sentry Crash Report:
Attachments:	missing context help button on Plasma 5.17.1

Description Alison Watson 2019-10-18 13:45:39 UTC

SUMMARY

Aurorae, from what I could gather, supports the Context Help button via help.svg, but despite that it does not use it and displays nothing where the Context Help button is supposed to be. This bug apparently existed for the Shade button as well for a long time before being fixed.

STEPS TO REPRODUCE
1. Add "Context Help" to the menu bar.
2. Install an Aurorae theme.
3. Enable it.

OBSERVED RESULT

There is no context help button.

EXPECTED RESULT

The context help button should exist as specified by help.svg in the theme.

SOFTWARE/OS VERSIONS
KDE Plasma Version: 5.16.5
KDE Frameworks Version: 5.62.0
Qt Version: 5.13.1

Comment 1 Alison Watson 2019-10-18 13:50:21 UTC

I somehow managed to write "menu bar" instead of "window decorations."

Comment 2 Vlad Zahorodnii 2019-10-22 08:22:41 UTC

Git commit 982fefd38974667d818b0b91698db7defe62483a by Vlad Zahorodnii.
Committed on 22/10/2019 at 08:21.
Pushed by vladz into branch 'Plasma/5.17'.

[aurorae] Fix visibility of Context Help button

Summary:
providesContextHelp is a property of DecoratedClient, not Decoration.
FIXED-IN: 5.17.1

Reviewers: #kwin, davidedmundson

Reviewed By: #kwin, davidedmundson

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D24851

M  +1    -1    plugins/kdecorations/aurorae/src/qml/AuroraeButton.qml

https://commits.kde.org/kwin/982fefd38974667d818b0b91698db7defe62483a

Comment 3 Patrick Silva 2019-10-24 21:28:15 UTC

Created attachment 123466 [details]
missing context help button on Plasma 5.17.1

Context help button is still missing on my system after update to Plasma 5.17.1.
I use sweet aurorae theme.

Operating System: Arch Linux 
KDE Plasma Version: 5.17.1
KDE Frameworks Version: 5.63.0
Qt Version: 5.14.0 beta2

Comment 4 Vlad Zahorodnii 2019-10-24 23:46:04 UTC

Most likely that decoration theme doesn't have help.svg file. Can you provide a link to this sweet decoration theme?

Comment 5 Patrick Silva 2019-10-25 11:06:04 UTC

(In reply to Vlad Zahorodnii from comment #4)
> Most likely that decoration theme doesn't have help.svg file. Can you
> provide a link to this sweet decoration theme?

https://store.kde.org/p/1286856/

Comment 6 Vlad Zahorodnii 2019-10-25 12:04:47 UTC

(In reply to Patrick Silva from comment #5)
> (In reply to Vlad Zahorodnii from comment #4)
> > Most likely that decoration theme doesn't have help.svg file. Can you
> > provide a link to this sweet decoration theme?
> 
> https://store.kde.org/p/1286856/

That decoration theme doesn't provide help.svg file. Report this issue to the author of the theme.