Bug 413111

Created attachment 123291 [details]
firefox theme settings

Created attachment 123292 [details]
KDE GTK application theme

apologies, the first attachment "firefox theme settings" (the 97KB one) is a screenshot of Firefox demonstrating the problem. The second attachement labelled that (24KB) is Firefox's theme settings. Not sure how to fix that.

If I'm understanding you, what you want is to have all GTK apps *except* for Firefox respect your dark theme? Can I ask why?

Created attachment 123873 [details]
DBeaver GTK example

example of the mixed light/dark issue with the app DBeaver

Hmm, I thought we were talking about Firefox here. Your screenshot depicts a separate issue that was just fixed in Plasma 5.17.3; see Bug 413107 and verify with Plasma 5.17.3 to see if that fixes that issue.

Can you clarify what the Firefox issue is? Another screenshot would be helpful.

So the issue is that I would like my overall KDE theme and Qt apps to be "Breeze Dark" and *all* GTK apps to be "Breeze" (light). 

This was previously working fine, but seems to have recently broken.

Firefox was the most noticeable example of these settings misbehaving, but after a bit further usage I've found it applies to other apps as well. I've attached a screenshot of DBeaver which is showing the same issues (see attachment). It's overall trying to use the Breeze light theme, but certain GUI elements are still showing in dark.

So apologies, I guess I didn't explain well and this ticket might be overly specific about firefox.

Some further messing around I've found the following:
* The same thing happens with a new user account on my current system and a VM of KDE Neon. Change KDE's Theme to "Breeze Dark" and keep GTK theme as "Breeze", restart, and firefox will launch dark, DBeaver has the weird look (see attachment)
* changing the application launch command to "GTK_Theme=BreezeFirefox:light firefox..." seems to mostly right things. Everything is "light", though not exactly matching. I found that in a random forum. There doesn't seem to be a combination of "Breeze" or "Breeze:light" or similar that works, it has to be "BreezeFirefox".

So I'm not sure if this is an issue with KDE's themes and settings, KDE Neon's packaging, or something else. I took a best guess at the Product/Component.

I hope that helps?

Created attachment 123875 [details]
Apps and Settings

Sorry, not used to bugzilla so there was a delay between my screenshot and reply. 

One more screenshot from a fresh user account. Both Firefox and KDE settings/profiles should all be using out-of-the-box defaults here. Steps:
1) Make a new account
2) set global theme to "Breeze Dark" (not shown)
3) make sure the GTK themes are "Breeze" (shown)
4) log out/login or restart
5) Open Firefox. Notice it's completely dark (should be light)
6) Open another GTK App (DBeaver here). Notice the mix of dark and light widgets.

I took a look at the other bug and that looks promising! I'll wait for the update and report back if that fixes it.

>So the issue is that I would like my overall KDE theme and Qt apps to be
> "Breeze Dark" and *all* GTK apps to be "Breeze" (light). 
OK. Marking this as a feature request since I think most people prefer consistency, judging by the number of bug reports we got requesting that. :)

Fortunately, there is already a patch that would make this work: https://phabricator.kde.org/D24122

I had objected to it at the time it was submitted, but it looks like I wasn't fully understanding why someone would want this ability, and thanks to you, I do now. I'll see about getting that added.

It's not just for preference. For me I want all apps dark. However, since Firefox uses the GTK theme as the base style for some web content, using a dark GTK theme will break some web sites. Setting "widget.content.gtk-theme-override" to "Breeze" used to fix this, making the web content use a light theme, while the UI uses a light theme. Presumably, in the future it should instead be set to "Breeze-Light".

> However, since Firefox uses the GTK theme as the base style for some web
> content, using a dark GTK theme will break some web sites.
This seems like a bug in Firefox more than a bug in our theming of it. Can you file a bug on Firefox's bugtracker about this? https://bugzilla.mozilla.org/

The did apparently recently change it to use Adwaita by default if you have a dark theme (https://bugzilla.mozilla.org/show_bug.cgi?id=1527048), though that won't help if you want the content to use Breeze widgets.

Carson, is there anything we can do here, or does everything need to be fixed on Mozilla's side with https://bugzilla.mozilla.org/show_bug.cgi?id=1527048 and/or https://bugzilla.mozilla.org/show_bug.cgi?id=1411425?

Lots of people are commenting firefox here. Actually, trying to use the breeze light theme with Chrome also causes a problem if you use the GTK+ theme in Chrome. The title bar will be in white, but the max/min/close buttons will be from the standard dark title bar decorations, meaning they are invisible until you hover over them.

+1, i'm using zulip which auto-switch mode from light to dark(and reverse) according from system preference. i switch to "Breeze Dark" but zulip theme stay light. the same behaviour was in google chrome which became dark after set theme to GTK+.

I'd like to add to the wish for "forced" dark or light breeze GTK.
I use Breeze Dark as a main theme and when i use Breeze for GTK, applications that have a darkmode-switch (like for example lutris) use the Breeze-Dark colorset. If the application does not have a darkmode-switch (like for example prusaslicer), it uses the light Breeze colorset.
So i would wish for distinct Breeze-Light-GTK and Breeze-Dark-GTK themes :)

Yes. Also, Inkscape does not recognize Dark Breeze theme for GTK apps.

Hm... Given the fact, that we cannot longer customize the Breeze GTK appearance in GTK4 with the current mechanism and the amount of confusion, that the single Breeze option in combobox gives to some users, I think what we can do is the following:

1. Create 3 Breeze GTK variants: Breeze Light, Breeze Dark and Breeze Native.
2. Breeze Native will be the default and will grab all its tweaks from some Plasma settings (color scheme, window decorations). Possibly Breeze Native will be auto-generated variant (Not yet sure how to do that exactly).
3. Breeze Light and Breeze Dark will use the standard Breeze Light and Breeze Dark color schemes.

That seems sensible to me.

Coming here as I re-discovered Firefox and it annoys me terribly it turns black when my GTK theme is "Breeze". Will the proposed resolution be in the next Plasma release?