Bug 413091

Created attachment 123280 [details]
screenshot

Is this a regression? I'm not sure I recall this working better in the past.

So the size should be the size of files in the trash, modified last time a file was added to the trash.
The accessed date is kind of weird for a trash, last time you opened the trash has not much value.

(In reply to Méven Car from comment #3)
> So the size should be the size of files in the trash, modified last time a
> file was added to the trash.
> The accessed date is kind of weird for a trash, last time you opened the
> trash has not much value.
Yeah for the trash itself, maybe we should just not show this piecee of information.

Git commit 52fa2deb944dccfce7fd740b0b441706ab77e451 by Méven Car.
Committed on 20/10/2019 at 14:08.
Pushed by meven into branch 'master'.

Allow non-local directories to provide UDS_SIZE

Summary:
FIXED-IN: 19.12

Relates to D24773

Reviewers: ngraham, elvisangelaccio, bruns, #dolphin

Reviewed By: elvisangelaccio, #dolphin

Subscribers: #baloo

Tags: #baloo

Differential Revision: https://phabricator.kde.org/D24774

M  +5    -0    src/filemetadataprovider.cpp

https://commits.kde.org/baloo-widgets/52fa2deb944dccfce7fd740b0b441706ab77e451

Not quite; will be fully fixed with https://phabricator.kde.org/D24773.

The same occurs when we select any entry under Remote, Recent, Search for and Tags sections of places panel.

Git commit 570b48e656c792dfd9fd2314ab77b84afca87da0 by Méven Car.
Committed on 14/04/2020 at 05:41.
Pushed by meven into branch 'master'.

kio_trash: Add size, modification, access and create date for trash:/

Summary:
FIXED-IN: 5.70

Reviewers: #frameworks, ngraham, elvisangelaccio, dfaure

Reviewed By: dfaure

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D24773

M  +21   -0    src/core/kfileitem.cpp
M  +11   -0    src/core/kfileitem.h
M  +4    -0    src/core/udsentry.h
M  +2    -3    src/ioslaves/trash/kio_trash.cpp
M  +30   -4    src/ioslaves/trash/trashimpl.cpp
M  +5    -0    src/ioslaves/trash/trashimpl.h
M  +50   -25   src/ioslaves/trash/trashsizecache.cpp
M  +14   -0    src/ioslaves/trash/trashsizecache.h

https://commits.kde.org/kio/570b48e656c792dfd9fd2314ab77b84afca87da0

Git commit 50fdd3e154ffac3b4b42cc03735255aca8272ae8 by Méven Car.
Committed on 14/04/2020 at 05:42.
Pushed by meven into branch 'master'.

Use KFileItem::recursiveSize to Display recursize size as total size

Summary:
This allows to display the trash:/ occupied space

Test Plan: {F8231067}

Reviewers: #dolphin, ngraham, elvisangelaccio, dfaure

Reviewed By: #dolphin, ngraham, elvisangelaccio, dfaure

Subscribers: #baloo

Tags: #baloo

Differential Revision: https://phabricator.kde.org/D28738

M  +1    -1    CMakeLists.txt
M  +5    -2    src/filemetadataprovider.cpp

https://commits.kde.org/baloo-widgets/50fdd3e154ffac3b4b42cc03735255aca8272ae8

*** Bug 420067 has been marked as a duplicate of this bug. ***

Git commit 44c4f46b584b4337944d4611eaa3419701616970 by Méven Car.
Committed on 25/04/2020 at 20:14.
Pushed by meven into branch 'master'.

FileMetaDataWidget: Avoid showing fields when they have no value

Summary:
When displaying remote:/ recentlyused:/, Search:/ or and Tags:/, the information panel shows modifications time, access time and size with empty field value.
This patches avoids displaying those fields when we have no value for them.
More precisely https://bugs.kde.org/show_bug.cgi?id=413091#c7

Test Plan:
Open remote:/ in Dolphin:
Size, Access and modification dates fields are not visible

Reviewers: #dolphin, ngraham, bruns

Reviewed By: #dolphin, ngraham, bruns

Subscribers: #baloo

Tags: #baloo

Differential Revision: https://phabricator.kde.org/D28972

M  +12   -8    src/filemetadataprovider.cpp

https://commits.kde.org/baloo-widgets/44c4f46b584b4337944d4611eaa3419701616970