Bug 412979

Summary: Okular creates additional tab for deleted file
Product: [Applications] okular Reporter: postix <postix>
Component: generalAssignee: Okular developers <okular-devel>
Status: RESOLVED FIXED    
Severity: normal CC: andysardina22, postix
Priority: NOR    
Version First Reported In: 1.8.1   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: https://invent.kde.org/kde/okular/commit/c549d28f7f963607075fb39322115d39e837d854 Version Fixed/Implemented In:
Sentry Crash Report:

Description postix 2019-10-15 16:16:31 UTC 
SUMMARY

Okular creates two tabs: One for the deleted file and one for the valid restored recently opened PDF. 
If the user opens another recent PDF, there's no additional tab for the deleted file.
If the user closes the tab of the valid PDF, both tabs are closed.

STEPS TO REPRODUCE
1. Open a PDF in Okular, delete this PDF on disk.
2. Close the tab and reopen the deleted file by File->Recently Opened
3. Warning appears and an empty tab is created
4. Close this empty tab, maybe restart Okular
5. Open another recently opened file, which exists

SOFTWARE/OS VERSIONS
Operating System: Manjaro Linux 
KDE Plasma Version: 5.16.5
KDE Frameworks Version: 5.63.0
Qt Version: 5.13.1
Comment 1 Albert Astals Cid 2020-02-10 23:22:08 UTC 
Git commit c549d28f7f963607075fb39322115d39e837d854 by Albert Astals Cid, on behalf of Andi Sardina Ramos.
Committed on 10/02/2020 at 23:22.
Pushed by aacid into branch 'master'.

Solving the creation of an additional tab for a deleted file.
Related: bug 412978

M  +2    -2    autotests/CMakeLists.txt
A  +41   -0    autotests/closedialoghelper.cpp     [License: UNKNOWN]  *
A  +39   -0    autotests/closedialoghelper.h     [License: UNKNOWN]  *
M  +61   -1    autotests/mainshelltest.cpp
M  +21   -65   autotests/parttest.cpp
M  +1    -1    autotests/testingutils.cpp
M  +1    -0    autotests/testingutils.h
M  +21   -2    core/document.cpp
M  +8    -0    core/document.h
M  +2    -0    core/document_p.h
M  +3    -1    part.cpp
M  +20   -10   shell/shell.cpp

The files marked with a * at the end have a non valid license. Please read: https://community.kde.org/Policies/Licensing_Policy and use the headers which are listed at that page.


https://invent.kde.org/kde/okular/commit/c549d28f7f963607075fb39322115d39e837d854
Comment 2 postix 2020-02-28 14:36:08 UTC 
*** Bug 418292 has been marked as a duplicate of this bug. ***