Bug 412953

Summary:	Compositions Docker exports duplicates of one composition when you export multiple.
Product:	[Applications] krita	Reporter:	Jim <snopmark>
Component:	Dockers	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	halla
Priority:	NOR
Version:	4.2.7-beta1
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:	https://invent.kde.org/kde/krita/commit/ecfcac09c91d27b22ed66bc676d478e361de45f3	Version Fixed In:
Sentry Crash Report:
Attachments:	kra file with embedded compositions and exported results Recorded Log Viewer Results as plain text file Just the Composition Export Results

Description Jim 2019-10-15 02:59:05 UTC

SUMMARY
Compositions Docker exports duplicates of one of the compositions if you export multiple compositions at once. Sometimes there's artifacts like it's in the middle of disabling or enabling view layers so it composited strangely.

STEPS TO REPRODUCE
1. Go to Compositions Docker and make at least two different compositions.
2. Have multiple compositions ticked, then export them.

OBSERVED RESULT
All the exported compositions are duplicates.
Sometimes an exported Composition will have artifacts on the image, like it was in the middle of turning on/off view layers.

EXPECTED RESULT
Multiple compositions exported without duplicates.

SOFTWARE/OS VERSIONS
Windows: Windows 64-bit Home.
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Krita Plus 4.2.7-beta1 (git e9b2584)

Comment 1 Halla Rempt 2019-10-15 07:41:20 UTC

Hm, I just tested this with current git master, and I get correct results. Could you share your test image with the compositions embedded?

Comment 2 Jim 2019-10-15 15:01:38 UTC

Created attachment 123206 [details]
kra file with embedded compositions and exported results

Comment 3 Jim 2019-10-15 15:02:57 UTC

Created attachment 123207 [details]
Recorded Log Viewer Results as plain text file

Comment 4 Jim 2019-10-15 15:13:15 UTC

Created attachment 123208 [details]
Just the Composition Export Results

Comment 5 Bug Janitor Service 2019-10-16 04:33:13 UTC

Thanks for your comment!

Automatically switching the status of this bug to REPORTED so that the KDE team
knows that the bug is ready to get confirmed.

In the future you may also do this yourself when providing needed information.

Comment 6 Halla Rempt 2019-10-16 12:04:08 UTC

Okay, I can confirm the issue with your test image.

Comment 7 Halla Rempt 2019-10-16 12:04:20 UTC

Git commit 30915e552498de7b23d7bda824bb4b9e08b828b7 by Boudewijn Rempt.
Committed on 16/10/2019 at 12:03.
Pushed by rempt into branch 'master'.

Refresh the compositions' projection before export

And restore the current composition after export.

M  +8    -3    libs/image/kis_layer_composition.cpp
M  +16   -6    plugins/dockers/compositiondocker/compositiondocker_dock.cpp

https://invent.kde.org/kde/krita/commit/30915e552498de7b23d7bda824bb4b9e08b828b7

Comment 8 Halla Rempt 2019-10-21 12:59:49 UTC

Git commit ecfcac09c91d27b22ed66bc676d478e361de45f3 by Boudewijn Rempt.
Committed on 21/10/2019 at 12:58.
Pushed by rempt into branch 'krita/4.2'.

Refresh the compositions' projection before export

And restore the current composition after export.

(cherry picked from commit 30915e552498de7b23d7bda824bb4b9e08b828b7)

M  +8    -3    libs/image/kis_layer_composition.cpp
M  +16   -6    plugins/dockers/compositiondocker/compositiondocker_dock.cpp

https://invent.kde.org/kde/krita/commit/ecfcac09c91d27b22ed66bc676d478e361de45f3