Bug 412948

Summary:	Deleting a versioned file leaves original hidden in thumbnail view
Product:	[Applications] digikam	Reporter:	Han Holl <han.holl>
Component:	Albums-Versioning	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	caulier.gilles
Priority:	NOR
Version First Reported In:	6.1.0
Target Milestone:	---
Platform:	Fedora RPMs
OS:	Linux
Latest Commit:	https://invent.kde.org/kde/digikam/commit/bb0a8d2ca05651d99171722de1690cda357da6de	Version Fixed In:	6.4.0
Sentry Crash Report:
Attachments:	attachment-4124-0.html

Description Han Holl 2019-10-14 19:56:54 UTC

SUMMARY
Create a _v1 version of any photograph.
The original is no longer visible in the thumbnail view.



STEPS TO REPRODUCE
1. Create a _v1 version of any photograph.
2. Delete the _v1 file
3. 

OBSERVED RESULT
The original file is not visible in the thumbnail view.
It is of course visble in the table view.

EXPECTED RESULT
Original file should be visible

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 5.15.5
KDE Frameworks Version: 5.59.0
Qt Version: 5.12.5

ADDITIONAL INFORMATION

Comment 1 Maik Qualmann 2019-10-15 19:44:00 UTC

Git commit bb0a8d2ca05651d99171722de1690cda357da6de by Maik Qualmann.
Committed on 15/10/2019 at 19:42.
Pushed by mqualmann into branch 'master'.

show original image after deleting a derived image
and mark original image for the next initial scan to resolve the history
FIXED-IN: 6.4.0

M  +2    -1    NEWS
M  +28   -3    core/libs/database/utils/ifaces/dio.cpp

https://invent.kde.org/kde/digikam/commit/bb0a8d2ca05651d99171722de1690cda357da6de

Comment 2 Maik Qualmann 2019-10-15 20:24:26 UTC

Git commit 949e19574898e05d104a5a97638fd8e73774f758 by Maik Qualmann.
Committed on 15/10/2019 at 20:22.
Pushed by mqualmann into branch 'master'.

add repair function for hidden versioned items

M  +21   -11   core/libs/album/treeview/albumselectiontreeview.cpp
M  +1    -1    core/libs/album/treeview/albumselectiontreeview.h

https://invent.kde.org/kde/digikam/commit/949e19574898e05d104a5a97638fd8e73774f758

Comment 3 Han Holl 2019-10-17 12:04:43 UTC

Hello,

Thanks a lot for the speedy fix. It looks a lot more complex than I would have thought.
I've seen that the 6.4.0 release is due on October 20, and thanks to the AppImage
system I don't have to wait for the official Fedora rpm.
I do have some other issues and questions to do with versioning, but I guess the digikam-users list is the appropriate place for that.

Cheers,

Han Holl

Comment 4 caulier.gilles 2019-10-17 14:44:40 UTC

Created attachment 123278 [details]
attachment-4124-0.html

Note : I'm sure that 6.4.0 will not be released for this date as AppImage
workflow is broken for this moment, i'm working on this.

Best

Gilles Caulier

Le jeu. 17 oct. 2019 à 08:04, Han Holl <bugzilla_noreply@kde.org> a écrit :

> https://bugs.kde.org/show_bug.cgi?id=412948
>
> --- Comment #3 from Han Holl <han.holl@pobox.com> ---
> Hello,
>
> Thanks a lot for the speedy fix. It looks a lot more complex than I would
> have
> thought.
> I've seen that the 6.4.0 release is due on October 20, and thanks to the
> AppImage
> system I don't have to wait for the official Fedora rpm.
> I do have some other issues and questions to do with versioning, but I
> guess
> the digikam-users list is the appropriate place for that.
>
> Cheers,
>
> Han Holl
>
> --
> You are receiving this mail because:
> You are watching the assignee of the bug.

Comment 5 Han Holl 2019-10-17 19:56:27 UTC

Ok, pity. Thanks for the warning.
I'll keep watching the news.
I suspect that "delete from Images where name = 'file_v1.jpg'" in my 6.1.0 will also fix the database.
Or i could rebuild the entire database occasionally.

Cheers,

Han Holl