| Summary: | Undoing selecting new area makes the previous selection invisible in global selection mask | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | acc4commissions |
| Component: | Tools/Selection | Assignee: | Dmitry Kazakov <dimula73> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ahab.greybeard, dimula73 |
| Priority: | NOR | ||
| Version: | nightly build (please specify the git hash!) | ||
| Target Milestone: | --- | ||
| Platform: | Microsoft Windows | ||
| OS: | Microsoft Windows | ||
| Latest Commit: | https://invent.kde.org/kde/krita/commit/f2394e71d5a126e9a8cf32323a4251a178302e34 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: |
recording
recording2 |
||
|
Description
acc4commissions
2019-10-10 11:13:11 UTC
Created attachment 123121 [details]
recording
This happens with the latest 4.3.0-prealpha (git 0cc05e0) appimage but only with the vector selection mode. The maching ants outline is 'false' and does not represent an active selction, but it should do. Setting to Confirmed Created attachment 123279 [details]
recording2
Found 2 new thigs.
1 If you select a new area that include the previous area before undoing it, the later operations is applied to the intersecting area.
2 It doesn't happen with contiguous selection tool.
(In reply to acc4commissions from comment #3) > 1 If you select a new area that include the previous area before undoing it, > the later operations is applied to the intersecting area. If you use outline selection tool to do this, the 'intersecting area' appears to be square-shaped, even though the original shape was different. (In reply to acc4commissions from comment #4) > If you use outline selection tool I was wrong. Appareantly it happens with all selection tools... Git commit 7a709c5480aa24bb693a937feb8465f5e0547c4e by Dmitry Kazakov. Committed on 19/11/2019 at 11:54. Pushed by dkazakov into branch 'master'. Fix undo of replacing vector selection When redoing KisTakeAllShapesCommand, we should keep the selection projection, but when undoing it, we should start a full-featured update to get a correct canvas state. It is needed because pixel selection is used as a projection in shape-mode, so undo/redo for it is not valid. M +5 -0 libs/image/kis_selection.cc M +2 -0 libs/image/kis_selection.h M +1 -1 libs/ui/flake/kis_shape_selection.cpp M +4 -0 libs/ui/flake/kis_shape_selection_model.cpp M +5 -4 libs/ui/flake/kis_take_all_shapes_command.cpp M +4 -1 libs/ui/flake/kis_take_all_shapes_command.h M +107 -0 libs/ui/tests/kis_shape_selection_test.cpp M +2 -0 libs/ui/tests/kis_shape_selection_test.h https://invent.kde.org/kde/krita/commit/7a709c5480aa24bb693a937feb8465f5e0547c4e Git commit f2394e71d5a126e9a8cf32323a4251a178302e34 by Agata Cacko, on behalf of Dmitry Kazakov. Committed on 09/01/2020 at 13:54. Pushed by tymond into branch 'krita/4.2'. Fix undo of replacing vector selection When redoing KisTakeAllShapesCommand, we should keep the selection projection, but when undoing it, we should start a full-featured update to get a correct canvas state. It is needed because pixel selection is used as a projection in shape-mode, so undo/redo for it is not valid. (cherry picked from commit 7a709c5480aa24bb693a937feb8465f5e0547c4e) M +5 -0 libs/image/kis_selection.cc M +2 -0 libs/image/kis_selection.h M +1 -1 libs/ui/flake/kis_shape_selection.cpp M +4 -0 libs/ui/flake/kis_shape_selection_model.cpp M +5 -4 libs/ui/flake/kis_take_all_shapes_command.cpp M +4 -1 libs/ui/flake/kis_take_all_shapes_command.h M +107 -0 libs/ui/tests/kis_shape_selection_test.cpp M +2 -0 libs/ui/tests/kis_shape_selection_test.h https://invent.kde.org/kde/krita/commit/f2394e71d5a126e9a8cf32323a4251a178302e34 |