| Summary: | Misleading descriptions of checkbox "forceStripes" | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Alexander Potashev <aspotashev> |
| Component: | Task Manager and Icons-Only Task Manager widgets | Assignee: | Eike Hein <hein> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bfeber, filipfila.kde, hein, kcohar, nate, plasma-bugs |
| Priority: | NOR | ||
| Version: | master | ||
| Target Milestone: | 1.0 | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/plasma-desktop/6b4295b313af62b745cadbe62d8a91947baed386 | Version Fixed In: | |
| Sentry Crash Report: | |||
Submitted a patch: https://phabricator.kde.org/D24534 Git commit 6b4295b313af62b745cadbe62d8a91947baed386 by Filip Fila. Committed on 20/10/2019 at 18:02. Pushed by filipf into branch 'Plasma/5.17'. [applets/taskmanager] Revert "forceStripes" checkbox string change Summary: I changed the "forceStripes" checkbox string in D19280, most likey because I thought it wasn't super understandable. The new string I pushed doesn't, however, match what the option does. So reverting the change. Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D24534 M +1 -1 applets/taskmanager/package/contents/ui/ConfigAppearance.qml https://commits.kde.org/plasma-desktop/6b4295b313af62b745cadbe62d8a91947baed386 |
SUMMARY Misleading descriptions of checkbox "forceStripes". In plasma-desktop/applets/taskmanager/package/contents/ui/ConfigAppearance.qml, two user-visible messages are now incorrect/misleading: text: plasmoidVertical ? i18n("Always arrange tasks in as many rows as columns") : i18n("Always arrange tasks in as many columns as rows") These messages were different before a recent change: text: vertical ? i18n("Always arrange tasks in rows of as many columns") : i18n("Always arrange tasks in columns of as many rows") Explaination: The new message "Always arrange tasks in as many rows as columns" suggests that the number of rows is equal to the number of columns. It contradicts the old message before change and also the current option description from package/contents/config/main.xml: <entry name="forceStripes" type="Bool"> <label>Whether to try and always layout task buttons in as many rows/columns as set via maxStripes.</label> Guilty commit: https://cgit.kde.org/plasma-desktop.git/commit/?id=5e905afb07e8cf7ea1a5dbc0def0507910feb752 STEPS TO REPRODUCE 1. 2. 3. OBSERVED RESULT EXPECTED RESULT SOFTWARE/OS VERSIONS Windows: macOS: Linux/KDE Plasma: (available in About System) KDE Plasma Version: KDE Frameworks Version: Qt Version: ADDITIONAL INFORMATION