| Summary: | Crashed when editing global selection mask (Safe assert: clonedDocument->image()->isIdle() at KisDocument.cpp 1006) | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | acc4commissions |
| Component: | Tools/Selection | Assignee: | Dmitry Kazakov <dimula73> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | griffinvalley, halla |
| Priority: | NOR | ||
| Version: | nightly build (please specify the git hash!) | ||
| Target Milestone: | --- | ||
| Platform: | Microsoft Windows | ||
| OS: | Microsoft Windows | ||
| Latest Commit: | https://invent.kde.org/kde/krita/commit/b1bccb81547bff95e9e4d737771439106d6e94b2 | Version Fixed In: | |
| Attachments: |
attachment
capture |
||
|
Description
acc4commissions
2019-10-09 04:28:03 UTC
Hi, I'm sorry, but I haven't been able to reproduce this. I tried: * create a new document * select an ellipse * select/show global selection mask * select the select shape tool * move or rotate the selection Can you get the assert reliable using steps like this? This crash looks to be the same as in bug 412835. And I fixed it on Monday :) *** This bug has been marked as a duplicate of bug 412835 *** Created attachment 123275 [details]
capture
I've got the assert message again, looking like the similar issue.
git eb5dfa0 It happens when krita autosaves. Steps : 1 Select an area 2 Select the global selection mask(layer), 3 Wait for krita to autosave 4 Assert It also happens with raster selections. I can reproduce it, thank you! Git commit 77717dbb719642382c243f4834795e2546d2de22 by Dmitry Kazakov. Committed on 13/11/2019 at 10:46. Pushed by dkazakov into branch 'master'. Disconnect move tool from canvas signals when it is not activated M +4 -3 plugins/tools/basictools/kis_tool_move.cc M +1 -0 plugins/tools/basictools/kis_tool_move.h https://invent.kde.org/kde/krita/commit/77717dbb719642382c243f4834795e2546d2de22 Git commit c1f5d964ac8eb6cd78cd4ba46fa8b1f53bce579a by Dmitry Kazakov. Committed on 13/11/2019 at 10:46. Pushed by dkazakov into branch 'master'. Fix KisShapeSelection not to cause any updates while cloning M +9 -1 libs/ui/flake/kis_shape_selection.cpp https://invent.kde.org/kde/krita/commit/c1f5d964ac8eb6cd78cd4ba46fa8b1f53bce579a Git commit be44f67e94f9dcb3e03d07bc4cec8f604555733c by Dmitry Kazakov. Committed on 13/11/2019 at 10:46. Pushed by dkazakov into branch 'master'. Fix KisSelectionMask not to cause any updates when cloning M +10 -4 libs/image/kis_selection_mask.cpp https://invent.kde.org/kde/krita/commit/be44f67e94f9dcb3e03d07bc4cec8f604555733c Git commit b1bccb81547bff95e9e4d737771439106d6e94b2 by Dmitry Kazakov. Committed on 13/11/2019 at 10:46. Pushed by dkazakov into branch 'master'. Fix cloning of the image with overlay selection mask When cloning the image with a copy-ctor it should have exactly the same state as before cloning. It includes the state of the overlay selection mask. It guarantees that there will be no async jobs running right after the operation. When saving, we don't want the overlay mask be saved into the file, therefore we should run a separate action to disable it. M +8 -8 libs/image/kis_image.cc M +10 -5 libs/image/tests/kis_image_test.cpp M +6 -0 libs/ui/KisDocument.cpp https://invent.kde.org/kde/krita/commit/b1bccb81547bff95e9e4d737771439106d6e94b2 Git commit fd1a6dbabf4c2c1a4886c81756af5e3d8946ef22 by Dmitry Kazakov. Committed on 14/11/2019 at 09:10. Pushed by dkazakov into branch 'krita/4.2'. Fix KisShapeSelection not to cause any updates while cloning M +9 -1 libs/ui/flake/kis_shape_selection.cpp https://invent.kde.org/kde/krita/commit/fd1a6dbabf4c2c1a4886c81756af5e3d8946ef22 Git commit 8ecdb5978bd7ed8b3a26d6c9ede6cd79bb34963b by Dmitry Kazakov. Committed on 14/11/2019 at 09:10. Pushed by dkazakov into branch 'krita/4.2'. Fix KisSelectionMask not to cause any updates when cloning M +10 -4 libs/image/kis_selection_mask.cpp https://invent.kde.org/kde/krita/commit/8ecdb5978bd7ed8b3a26d6c9ede6cd79bb34963b Git commit 53c2901a5756317677e338d6a79b2ea3bbd6bc90 by Dmitry Kazakov. Committed on 14/11/2019 at 09:23. Pushed by dkazakov into branch 'krita/4.2'. Fix cloning of the image with overlay selection mask When cloning the image with a copy-ctor it should have exactly the same state as before cloning. It includes the state of the overlay selection mask. It guarantees that there will be no async jobs running right after the operation. When saving, we don't want the overlay mask be saved into the file, therefore we should run a separate action to disable it. # Conflicts: # libs/image/kis_image.cc M +11 -2 libs/image/kis_image.cc M +10 -5 libs/image/tests/kis_image_test.cpp M +6 -0 libs/ui/KisDocument.cpp https://invent.kde.org/kde/krita/commit/53c2901a5756317677e338d6a79b2ea3bbd6bc90 Git commit 1b027e4fbc2ec88ac69bb556149e35fcbb466418 by Dmitry Kazakov. Committed on 14/11/2019 at 09:10. Pushed by dkazakov into branch 'krita/4.2'. Disconnect move tool from canvas signals when it is not activated M +4 -3 plugins/tools/basictools/kis_tool_move.cc M +1 -0 plugins/tools/basictools/kis_tool_move.h https://invent.kde.org/kde/krita/commit/1b027e4fbc2ec88ac69bb556149e35fcbb466418 |