Bug 412697

Summary:	Meta+L keyboard shortcut to lock screen
Product:	[Unmaintained] kscreenlocker	Reporter:	Alejandro Moreno Calvo <almorca>
Component:	general	Assignee:	Plasma Bugs List <plasma-bugs-null>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	bshah, kde, kdelibs-bugs-null, nate
Priority:	NOR	Keywords:	junior-jobs, usability
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Patch without testing

Description Alejandro Moreno Calvo 2019-10-07 12:42:43 UTC

In order to improve adaptation of Windows users to KDE would be great that some of the most commons shortcuts were similar between Windows and KDE.

For example:
Meta+L --> Lock desktop
Meta+D --> Show desktop

This shortcuts actually have not used on KDE and can be defined as alternate shortcuts.

Comment 1 Nate Graham 2019-10-07 13:38:46 UTC

Meta+D is already implemented. Meta+L is a pretty common request too. I think we can add that as well.

You can see how I implemented Meta+D for show desktop here: https://cgit.kde.org/kwin.git/commit/?id=c795f1389b63803f71aafe33a956ed50c14e3bb4

would you like to try your hand at doing it yourself and sending a patch? I can help you! See https://community.kde.org/Get_Involved/development and https://community.kde.org/Infrastructure/Phabricator.

Comment 2 David Edmundson 2019-10-07 14:05:26 UTC

See also T11520 which tracks it at a more systematic level. We shouldn't try and code something in conflict.

Comment 3 Nate Graham 2019-10-07 14:08:01 UTC

Yeah. There's general agreement in T11520 that the Meta key should be used exclusively for global shortcuts and never by apps, which is for the most part what we and apps already do. So I don't think there's any conflict there.

Comment 4 Alejandro Moreno Calvo 2019-12-26 08:37:17 UTC

Created attachment 124722 [details]
Patch without testing

Comment 5 Alejandro Moreno Calvo 2019-12-26 08:41:50 UTC

I think I have writen a correct patch.

I had the doubt of where to look for the text to put in I18N_NOOP. I have chosen the text by searching in https://l10n.kde.org/stats/gui/stable-kf5/team/es/kde-workspace/, is that correct?

Nowadays I haven't a test environment to test this patch.

Comment 6 Nate Graham 2019-12-26 15:35:04 UTC

Yep, that's fine. Please feel free to submit your patch using https://phabricator.kde.org. Here is the documentation: https://community.kde.org/Infrastructure/Phabricator

Comment 7 Nate Graham 2019-12-26 19:25:44 UTC

Actually, I completely forgot that I already implemented this earlier in the  year: https://phabricator.kde.org/D20178

Comment 8 Alejandro Moreno Calvo 2019-12-27 08:51:22 UTC

Thank you Nate

Comment 9 Nate Graham 2019-12-27 18:15:07 UTC

You're welcome!