| Summary: | Krita 4.2.7 fails to build with Qt 5.9 | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Wolfgang Bauer <wbauer1> |
| Component: | General | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | halla |
| Priority: | NOR | ||
| Version First Reported In: | 4.2.7 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
Introduced by https://cgit.kde.org/krita.git/commit/?h=krita/4.2&id=9604f0549d8b63d9e646853e9294a8cf450a96d2 . This should fix it: (untested) diff --git a/libs/flake/text/KoSvgTextShape.cpp b/libs/flake/text/KoSvgTextShape.cpp index 6ad42a4..b558a44 100644 --- a/libs/flake/text/KoSvgTextShape.cpp +++ b/libs/flake/text/KoSvgTextShape.cpp @@ -381,7 +381,11 @@ private: KIS_SAFE_ASSERT_RECOVER_NOOP(skippedChar.isSpace() || !skippedChar.isPrint()); QFontMetrics metrics(format.font()); +#if QT_VERSION >= QT_VERSION_CHECK(5,11,0) return metrics.horizontalAdvance(skippedChar); +#else + return metrics.width(skippedChar); +#endif } static QTextCharFormat formatForPos(int pos, const QVector<QTextLayout::FormatRange> &formats) I so wish people would build beta's... Then we would have caught this before I create the 4.2.7 tarball. I guess I'll do a 4.2.7.1 tarball now. Yes, I pushed that to the branch just now, too. Confirmed, it builds fine now with 5.9. The new 4.2.7.1 tarballs on download.kde.org are broken though, they only contain the translations... Argh, I shouldn't try to do releases on a long train trip. Fortunately, the tarballs weren't in the 4.2.7 folder yet, so I can recreate them and put them in the right place. Thanks for the warning! Okay, the current tarballs look good... Yes, and they build fine (also with Qt 5.9). Thank you! |
/home/abuild/rpmbuild/BUILD/krita-4.2.7/libs/flake/text/KoSvgTextShape.cpp:395:24: error: 'class QFontMetrics' has no member named 'horizontalAdvance' return metrics.horizontalAdvance(skippedChar); ^~~~~~~~~~~~~~~~~ QFontMetrics::horizontalAdvance was introduced in Qt 5.11...