| Summary: | Information Panel confusingly includes hidden files in the file count | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | Patrick Silva <bugseforuns> |
| Component: | panels: information | Assignee: | Dolphin Bug Assignee <dolphin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | CC: | kfm-devel, meven29, nate, pip.kde |
| Priority: | HI | Keywords: | usability |
| Version: | 19.08.1 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/baloo-widgets/e72b3d7ea495b5f21bc1b83f564f32cb6d27948e | Version Fixed In: | 19.12 |
| Attachments: |
screenshot
dolphin showing hidden files |
||
Info panel is counting hidden "dot" files ??? So you have 14 folders and 34 hidden files... Created attachment 122908 [details] dolphin showing hidden files (In reply to Paul from comment #1) > Info panel is counting hidden "dot" files ??? > > So you have 14 folders and 34 hidden files... yes, it is. IIRC this is only supposed to include hidden files when hidden files are visible. I guess that broke recently. Just for information... On an openSUSE Leap 15.1 system which currently has Dolphin 18.12.3 the behaviour is the same, i.e. hidden files/folders are included in the count shown, irrespective of the state of show hidden files. I would say this is intended, or do we want users to always toggle hidden files to check before they are going to delete a folder they think is empty? Personally, I think the current behaviour is "correct". The information panel should show the total number of items, irrespective of whether they are hidden or not. I nicety would be to have it show "x items (y hidden)" ... :) Even if it's intended it's super confusing because unless you know 1) that hidden files exist and 2) that this count includes then, the count just looks wrong, as evidenced by the bug report. I like Paul's idea of separating out the number of hidden and non-hidden files, since that not onlly improves clarity, but also teaches users that hidden files are a thing. maybe "Size: X items" can be replaced with "Items: X (Y hidden)". I have opened a patch proposal https://phabricator.kde.org/D24362 that will hide hidden files from information counts. Git commit e72b3d7ea495b5f21bc1b83f564f32cb6d27948e by Méven Car. Committed on 09/10/2019 at 06:58. Pushed by meven into branch 'master'. Don't count hidden files in folder item count Summary: Add a field "Hidden items" to display the number of hidden items, allowing the user to show or hide it. FIXED-IN: 19.12 Reviewers: ngraham, bruns, elvisangelaccio Reviewed By: ngraham, elvisangelaccio Subscribers: alexde, elvisangelaccio, cfeck, #baloo Tags: #baloo Differential Revision: https://phabricator.kde.org/D24362 M +46 -13 src/filemetadataprovider.cpp M +3 -3 src/filemetadataprovider.h https://commits.kde.org/baloo-widgets/e72b3d7ea495b5f21bc1b83f564f32cb6d27948e |
Created attachment 122903 [details] screenshot SUMMARY See the attached screenshot. I have 14 folders in my Home, but info panel says that I have 48 items. EXPECTED RESULT info panel shows the correct amount of files/folders present in current folder. SOFTWARE/OS VERSIONS Operating System: Arch Linux KDE Plasma Version: 5.16.90 KDE Frameworks Version: 5.62.0 Qt Version: 5.13.1