Bug 412328

Summary: Tabbar icons disappear after session restore
Product: [Applications] konsole Reporter: Michal Kec (MiK) <KDE>
Component: tabbarAssignee: Konsole Developer <konsole-devel>
Status: RESOLVED FIXED    
Severity: normal CC: mg, teplik
Priority: NOR    
Version: 19.12.2   
Target Milestone: ---   
Platform: Neon   
OS: Linux   
Latest Commit: Version Fixed In:
Attachments: Note the tabs: Left window is newly opened, right one is restored from the session

Description Michal Kec (MiK) 2019-09-25 17:22:11 UTC
Created attachment 122867 [details]
Note the tabs: Left window is newly opened, right one is restored from the session

Although I don't agree with the aesthetic reasons for hiding the "default" terminal icon off tabs (as discussed on https://phabricator.kde.org/D17747), I got used for it. Thus I've replaced good old "utilites-terminal" icon for "preferences-desktop-display" and live happily until the last update. Now even my specifically chosen icons disappeared - just after the session restore.


STEPS TO REPRODUCE
1. Start Konsole and make sure you have chosen non-default icons to your profiles. You can choose preferences-desktop-display for example, but it doesn't matter.
2. Open several tabs of your desired profile. You can see the icons on the tabs now.
3. Enable session restore in Plasma settings, if not enabled already.
4. Kindly restart the Plasma session and check the result.

EXPECTED RESULT
Plasma should restore the session with all apps and their windows state.

OBSERVED RESULT
Konsole gets restored with all tabs, but no icons on.


SOFTWARE/OS VERSIONS
KDE neon 5.16 User Edition
KDE Plasma Version: 5.16.5
KDE Frameworks Version: 5.62.0
Qt Version: 5.12.3

ADDITIONAL INFORMATION
This behavior happened since update just about a week ago. Reproducible always, even after closing the Konsole and opening new window with new tabs (and new session). 
I can see differences in the syntax of the session files in ~/.config/session/konsole* - the third line used to be "Sessions=1,4,2,3,7,5,6,8", newer files contains "Tabs=[{"Orientation":"Horizontal","Widgets":[{"SessionRestoreId":1}]}," instead.
Comment 1 Kurt Hindenburg 2019-10-06 16:12:33 UTC
Yes, I've noticed similar issues w/ a non-default profile icon.
Comment 2 Andrey 2020-02-21 13:13:39 UTC
Still in 19.12.2
Comment 3 Marcin Gryszkalis 2020-02-26 12:42:22 UTC
It applies to all restored sessions (with different profiles) - all icons are lost but other profile settings (like colors) are used.
Comment 4 Michal Kec (MiK) 2020-11-18 09:56:40 UTC
I can see the icons are fixed, at least with my Konsole 20.08.3.

Thank you for your attention.