Bug 412323

Summary:	Still-frame of last used brush shown instead of "No Preview for this engine"
Product:	[Applications] krita	Reporter:	M <manuel.snudl.zeidler>
Component:	Usability	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	griffinvalley, srirupa.sps, tamtamy.tymona
Priority:	NOR	Keywords:	regression
Version First Reported In:	git master (please specify the git hash!)
Target Milestone:	---
Platform:	Manjaro
OS:	Linux
Latest Commit:	https://invent.kde.org/graphics/krita/commit/aaf42e1328e5b4b871628da44d5831f25ee16d9b	Version Fixed/Implemented In:
Sentry Crash Report:

Description M 2019-09-25 14:13:41 UTC

SUMMARY
The stroke preview of the brush editor now stays on the last working brush preview instead of showing the "No Preview for this engine" message for those that don't support it, like the Clone, Quick or Shape engine. This happens in master (git f867486), but not in 4.2.6.

STEPS TO REPRODUCE
1. Open the brush settings
2. Switch between presets that generate a stroke preview and one that doesn't

OBSERVED RESULT
The generated stroke preview of the last working preset stays.

EXPECTED RESULT
The "No Preview for this engine" message should appear, like in 4.2.6.

SOFTWARE/OS VERSIONS
Krita master (git f867486)

Comment 1 wolthera 2019-09-25 14:14:46 UTC

Yeah, can confirm.

Comment 2 Dmitry Kazakov 2021-06-04 05:05:48 UTC

Git commit aaf42e1328e5b4b871628da44d5831f25ee16d9b by Dmitry Kazakov, on behalf of Srirupa Datta.
Committed on 04/06/2021 at 05:05.
Pushed by dkazakov into branch 'master'.

Show "No Preview" for presets that don't support it

GUI:
FIXED IN: 5.0.0

M  +7    -4    libs/ui/widgets/kis_preset_live_preview_view.cpp

https://invent.kde.org/graphics/krita/commit/aaf42e1328e5b4b871628da44d5831f25ee16d9b