Bug 412293

Summary:	Image editor Tools sidebar width not restored
Product:	[Applications] digikam	Reporter:	andrej.valencic
Component:	Usability-Ergonomy	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	minor	CC:	metzpinguin
Priority:	NOR
Version First Reported In:	6.4.0
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:	https://invent.kde.org/kde/digikam/commit/c2e610d96eda348448c73b25a64094fa71a40ec6	Version Fixed/Implemented In:	6.4.0
Sentry Crash Report:
Attachments:	Tools sidebar before using tools - 4 columns Sidebar after - 3 columns

Description andrej.valencic 2019-09-24 21:03:08 UTC

SUMMARY
After using any of the tools in Image Editor and confirming (OK) or canceling the changes the "Tools" sidebar becomes narrower - does not restore the size/width.

STEPS TO REPRODUCE
1. Chose a photo and click Image Editor (or F4) - the Tools sidebar is 4 columns wide
2. Use any of the tools in the sidebar and click OK or Cancel
3. Back to the Image Editor base view - the Tools sidebar is 3 columns wide
4. Manually change the sidebar size to show 4 columns and repeat steps 1-2 - again the sidebar becomes only 3 columns wide.

OBSERVED RESULT
No matter what the size of the sidebar before using any of the tools is, after returning to the base Image Editor view the size is only 3 columns wide. This is annoying because after that the tools change position in the sidebar and I have to look for them in different places. I tried setting the size of the sidebar to even more columns (like 6 or 7) and still after using a tool the size is back to 3 columns.

EXPECTED RESULT
Would like the size of the sidebar to stay the same whenever I'm using the Image Editor.

SOFTWARE/OS VERSIONS
Windows: 10
digiKam version: digiKam-6.4.0-git-20190924T120716-Win64
Linux/KDE Plasma:
(available in About System)
KDE Plasma Version:
KDE Frameworks Version: KDE Frameworks 5.61.0
Qt Version: Qt 5.13.1 (built against 5.13.1

ADDITIONAL INFORMATION
In the version 6.3 this does not happen and the sidebar always "comes back" with 4 columns width. And I don't know if it has anything to do whith this in the Settings I've got the "Restore the settings of the Image Editor tools" checked.

Comment 1 andrej.valencic 2019-09-24 21:03:59 UTC

Created attachment 122842 [details]
Tools sidebar before using tools - 4 columns

Comment 2 andrej.valencic 2019-09-24 21:06:08 UTC

Created attachment 122843 [details]
Sidebar after - 3 columns

Comment 3 Maik Qualmann 2019-09-25 06:34:51 UTC

I'm actually sure that there was no change compared to the 6.3.0. The sidebar strategy was always scaled down to a minimum size, but no scroll bars were visible. The idea is to provide maximum area for the image. I'll take a look at it this evening.

Maik

Comment 4 andrej.valencic 2019-09-25 09:15:41 UTC

Well that's strange then - maybe there were changes somewhere else because the behavior in my case is different in those two versions.

I just made a couple of screen captures for both version so you can check what I mean (they are from different machines but both Windows 10). I will also check this on my Linux  and report back.


https://we.tl/t-UP7y9XshEF

Comment 5 Maik Qualmann 2019-09-25 11:44:11 UTC

Ok, after a quick look in the code. The QSplitter state is saved and restored. Also works, a previously wide sidebar is restored. If you open a tool we go to minimum. After quitting the tool but the previous width is not restored, is now also minimum. I will revise it. The function for determining the desktop size has changed slightly in 6.3.0. But I do not know the current behavior any different.

Maik

Comment 6 Maik Qualmann 2019-09-27 21:27:26 UTC

Git commit c2e610d96eda348448c73b25a64094fa71a40ec6 by Maik Qualmann.
Committed on 27/09/2019 at 21:26.
Pushed by mqualmann into branch 'master'.

restore last sidebar size after use a editor tool
FIXED-IN: 6.4.0

M  +2    -1    NEWS
M  +20   -10   core/utilities/imageeditor/editor/editortooliface.cpp
M  +5    -0    core/utilities/imageeditor/editor/editorwindow.cpp
M  +1    -0    core/utilities/imageeditor/editor/editorwindow.h

https://invent.kde.org/kde/digikam/commit/c2e610d96eda348448c73b25a64094fa71a40ec6