Bug 412217

Summary: Dolphin FTP, copying files over existing files from the remote doesn't work anymore as expected after #409954
Product: [Frameworks and Libraries] frameworks-kio Reporter: Yann-Kaelig <jm.dev>
Component: FTPAssignee: David Faure <faure>
Status: RESOLVED WORKSFORME    
Severity: normal CC: kde, kdelibs-bugs-null, kfm-devel, nate, sitter, zawertun
Priority: NOR    
Version First Reported In: 5.62.0   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Yann-Kaelig 2019-09-22 20:57:41 UTC 
SUMMARY

Copying files over existing files from the remote doesn't work anymore as expected after #409954.
The window dialog do not show , but dolphin displays a 'successfully copied' message, which in fact is not the case.

STEPS TO REPRODUCE
1. Touch one or more files and copy them to the remote. 
2. On the remote edit and change the content of the files.
3. Copy one file from the remote. ( It may work the first time and the window dialog appears ) In this case
4. Repeat the copy from the remote but this time select two or more files from the remote
5. Repeat the copy from the remote.

OBSERVED RESULT

The window dialog do not show but dolphin displays a 'successfully copied' message.

EXPECTED RESULT

Operating System: Obarun Linux 
KDE Plasma Version: 5.16.5
KDE Frameworks Version: 5.62.0
Qt Version: 5.13.1
Kernel Version: 5.3.0-arch1-1-ARCH
OS Type: 64-bit
Processors: 2 × AMD Phenom(tm) II X2 550 Processor
Memory: 11,7 GiB of RAM


ADDITIONAL INFORMATION
Comment 1 Yaroslav Sidlovsky 2019-09-23 17:28:49 UTC 
Wow, someone actually tested my commit after merge, thanks :)

Looks like change of line 2375 in the ftp.cpp `if (cs == statusServerError && iError)` -> `if(iError)` should fix this. (https://github.com/KDE/kio/blob/57780c20b00aeefa9dff23105242b0bf2eb649fb/src/ioslaves/ftp/ftp.cpp#L2375).
Comment 2 Nate Graham 2019-09-24 03:41:38 UTC 
I don't suppose you would like to submit a patch? :)
Comment 3 Yaroslav Sidlovsky 2019-09-24 08:47:27 UTC 
Please submit it yourself.
Just do some testing first.

I have tested it at home with vsftpd (it gives 
access to user home with default config on Fedora without extra configuration).
Comment 4 Harald Sitter 2019-09-24 09:47:08 UTC 
There is a large rework of error reporting coming in https://phabricator.kde.org/D23579 I'd wait for that before adding more conditions.
Comment 5 Harald Sitter 2019-10-14 11:30:33 UTC 
I think(tm) this should be working again with git master (to be frameworks 5.64). I did the reproduction steps and all seems fine on my system anyway.

Would be good if a second person could verify though.
Comment 6 Bug Janitor Service 2019-10-29 04:33:09 UTC 
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 7 Bug Janitor Service 2019-11-13 04:33:10 UTC 
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!