Bug 412170

Summary:	Chromium incognito should (optionally) provide breeze-dark window borders, to match the GTK theme
Product:	[Plasma] Breeze	Reporter:	Andrew Brouwers <abrouwers>
Component:	gtk theme	Assignee:	Janet Blackquill <uhhadd>
Status:	RESOLVED DOWNSTREAM
Severity:	normal	CC:	nate
Priority:	NOR
Version:	5.16.90
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	Incognito1 Incognito2

Description Andrew Brouwers 2019-09-21 19:30:50 UTC

SUMMARY

I use breeze-light color scheme, generally (with a few overrides, such as konsole).  I was excited to read the following from the changelog for 5.17:

"Our Breeze GTK theme now provides a better appearance for the Chromium/Chrome web browsers and applies your color scheme to GTK and GNOME apps."

However, a feature I still find missing is launching chromium as an incognito instance.  When selecting "use GTK theme" from chromiums settings, I get a darker theme, as expected.  However, my window titlebars are still breeze-light, which looks poor.  On gnome, for example, the title bar darkens to match the theme.  Unfortunately, it doesn't seem possible to create a rule for an incognito instance, since it just shows "chromium."

STEPS TO REPRODUCE
1. Set breeze-light, install breeze-gtk, set chromium to use "GTK" theme instead of classic
2. Open incognito instance of chromium


OBSERVED RESULT
Breeze-light window border does not match GTK theme.

EXPECTED RESULT
Breeze-dark would instead be used to match darker GTK theme

SOFTWARE/OS VERSIONS

Linux/KDE Plasma: 5.16.90
KDE Frameworks Version: 5.62.0
Qt Version: 5.13.1

Comment 1 Nate Graham 2019-10-07 03:52:20 UTC

Carson, is this even possible to fix?

Comment 2 Nate Graham 2019-11-30 06:17:12 UTC

Can you attach a screenshot that shows the issue? When I use the Breeze Dark color scheme, Chromium-incognito-with-CSD has a border that matches the rest of the window.

Comment 3 Andrew Brouwers 2019-11-30 12:02:18 UTC

Created attachment 124204 [details]
Incognito1

Comment 4 Andrew Brouwers 2019-11-30 12:02:35 UTC

Created attachment 124205 [details]
Incognito2

Comment 5 Andrew Brouwers 2019-11-30 12:05:34 UTC

Sure, I've uploaded some screenshots.  My use is actually breeze light, but expecting the Chromium Incognito window to use dark window borders.

Thinking more about it, I think what I want isn't technically possible.  I use BreezeEnhanced, usually, with my controls on the left hand side (ala MacOS).  For that reason, using the GTK theme / border (instead of system) isn't possible, because it uses the regular breeze buttons (and, won't put them on the "left" side, ala screenshot #2).

Comment 6 Nate Graham 2019-11-30 15:39:01 UTC

Yep, I'm afraid what you want is indeed not possible. incognito1 depicts using the systemwide titlebar, which has no way to know what the application drawn beneath it looks like. If you want app-specific integration between the app and its titlebar (or lack thereof), you need to use CSDs, as depicted by incognito2. Of course if you do that, the appearance is sup to the app itself. You'd need to file a bug on Chromium itself.

Comment 7 Nate Graham 2019-11-30 15:39:13 UTC

Yep, I'm afraid what you want is indeed not possible. incognito1 depicts using the systemwide titlebar, which has no way to know what the application drawn beneath it looks like. If you want app-specific integration between the app and its titlebar (or lack thereof), you need to use CSDs, as depicted by incognito2. Of course if you do that, the appearance is sup to the app itself. You