Bug 412149

Summary:	Colorize mask color swatch index gets shuffled when setting transparent
Product:	[Applications] krita	Reporter:	Ralek Kolemios <info>
Component:	Tools/Colorize	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	ahab.greybeard, cadaverous.doll, dwilches, griffinvalley, halla, info, niharika.mvns, raghu, tamtamy.tymona, vaderpizza3
Priority:	NOR
Version:	nightly build (please specify the git hash!)
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:	4a37f35f9a5c26c2e412041be46c61e5417f9f52	Version Fixed In:

Description Ralek Kolemios 2019-09-21 06:14:27 UTC

SUMMARY
When using the colorize mask, if you have more than 16 color swatches set, then setting a single color as 'transparent' shifts colors around in an odd and completely toolbreaking way.
I believe this is the same bug as #409800 but the user neglected to mention that this only happens with 16+ colors.

STEPS TO REPRODUCE
1. Create a colorize mask and assign >16 color swatches
2. Set one of the swatches to transparent.

OBSERVED RESULT
Colors become scrambled in a strange yet consistent way.

EXPECTED RESULT
Color becomes transparent







Krita
  Version: 4.3.0-prealpha (git b6d75fa)

Qt
  Version (compiled): 5.12.5
  Version (loaded): 5.12.5

OS Information
  Build ABI: x86_64-little_endian-llp64
  Build CPU: x86_64
  CPU: x86_64
  Kernel Type: winnt
  Kernel Version: 10.0.17134
  Pretty Productname: Windows 10 (10.0)

Comment 1 wolthera 2019-09-21 14:13:54 UTC

Can confirm on Krita 4.3 on KDE Neon.

Comment 2 cadaverous.doll 2019-10-13 15:03:19 UTC

I wanted to add on that I have this same experience, also with more than 16 colors. I'm using 4.2.7.1

Comment 3 Daniel 2020-04-15 04:23:01 UTC

Happening too in Krita 4.2.9

Comment 4 Halla Rempt 2020-04-15 07:34:16 UTC

*** Bug 409800 has been marked as a duplicate of this bug. ***

Comment 5 Ahab Greybeard 2020-04-15 08:56:39 UTC

As noted here:
https://krita-artists.org/t/colorize-mask-shifts-the-color-palette/5483/2
If you set the transparent colour before you get to 16 colours in total, this does not happen with > 16 colours (single limited test performed).

Comment 6 Daniel 2020-04-17 04:34:54 UTC

I submitted a merge request for this bug here: https://invent.kde.org/kde/krita/-/merge_requests/305

And it says "Ask someone with write access to this repository to merge this request". Where should I ask that?

Comment 7 Halla Rempt 2020-04-17 07:31:14 UTC

Usually on #krita on irc.freenode.net or https://webchat.kde.org/#/room/#krita:kde.org which is linked to irc (but sometimes lags a lot). But merge requests also fall in our mailboxes, so I'm about to build and test your patch :-)

Note that if you add

BUG:412149

to the commit message, it will autoclose the bug on pushing to the central git repo.

Comment 8 Ahab Greybeard 2020-06-02 16:09:09 UTC

This seems to have been fixed in the 4.3.0 beta-2 appimage which was recently advised for download here: https://krita.org/en/item/second-beta-for-krita-4-3-0-released/
I haven't tried any other packages.